Clarify steps require for pixi installation #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flferretti
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Thanks a lot @traversaro, LGTM. I only added a small comment
CarlottaSartore
approved these changes
Jan 8, 2025
younik
approved these changes
Jan 8, 2025
xela-95
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Thanks @traversaro ! I left some comments, since with @younik we saw that the NOTE section inside a /details block is not rendered correctly.
It render fines outside of the |
flferretti
reviewed
Jan 9, 2025
xela-95
approved these changes
Jan 9, 2025
Co-authored-by: Filippo Luca Ferretti <[email protected]>
Co-authored-by: Filippo Luca Ferretti <[email protected]>
Co-authored-by: Alessandro Croci <[email protected]>
flferretti
force-pushed
the
traversaro-patch-1
branch
from
a5cef93 to
5295541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the current installation instructions were a bit confusing, as
pipandcondareported the instructions required for a downstream user to usejaxsimin their own project/environment, while the installation withpixireported the instructions required for a contributor to use run a source installation from thejaxsimrepo.I tried to clarify this, probably it could make sense if also @younik could provide some feedback has it has the advantage of being a new users that it may not familiar with the project and provide some feedback from the point of view of a new user.
📚 Documentation preview 📚: https://jaxsim--331.org.readthedocs.build//331/