Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize dashboard grid components #31240

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Dec 2, 2024

SUMMARY

This PR supersedes #30958.
Related to PRs: #31241, #31242, #31243, #31244.

Optimizes grid components such as Tabs, Tab, Row, Column by memoizing props passed to children and improving Redux selectors, leading to decreased number of redundant rerenders

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

For detailed perf improvement results, see the details in PR #30958

TESTING INSTRUCTIONS

No functional changes - the dashboard, native filters, cross filters, chart actions, etc. should work like before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje merged commit 5006f97 into apache:master Dec 2, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:performance Related to Dashboard performance size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants