Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Optimize DashboardPage and SyncDashboardState #31244

Merged
merged 1 commit into from
Dec 2, 2024
Merged

perf: Optimize DashboardPage and SyncDashboardState #31244

merged 1 commit into from
Dec 2, 2024

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Dec 2, 2024 •
edited
Loading

SUMMARY

This PR supersedes #30958.
Related to PRs: #31240, #31241, #31242, #31243.

Optimize DashboardPage and SyncDashboardPage by memoizing props and improving Redux selectors

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

For detailed perf improvement results, see the details in PR #30958

TESTING INSTRUCTIONS

No functional changes - the dashboard, native filters, cross filters, chart actions, etc. should work like before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje requested a review from geido December 2, 2024 13:12
@dosubot dosubot bot added the dashboard:performance Related to Dashboard performance label Dec 2, 2024
This was referenced Dec 2, 2024
Merged
Merged
Merged
Merged
@kgabryje kgabryje force-pushed the perf/optimize-dashboard-page branch from 1b62531 to 0a4a7c4 Compare December 2, 2024 14:09
@kgabryje kgabryje mentioned this pull request Dec 2, 2024
Closed
9 tasks
@kgabryje kgabryje force-pushed the perf/optimize-dashboard-page branch from 0a4a7c4 to d6739c3 Compare December 2, 2024 14:44
@kgabryje kgabryje merged commit 06fb330 into apache:master Dec 2, 2024
34 checks passed
@michael-s-molina michael-s-molina added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

Assignees
No one assigned
Labels
dashboard:performance Related to Dashboard performance size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgabryje @geido @michael-s-molina