Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize native filters and cross filters #31243

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Dec 2, 2024

SUMMARY

This PR supersedes #30958.
Related to PRs: #31240, #31241, #31242, #31244.

Optimizes utils and components related to native filters and cross filters. Many util functions, such as useSelectChartTabParents or getCrossFilterIndicator were suboptimal, running some operations unnecessarily, and were being called from components redundantly. This PR implements memoization in filter bar components, improves Redux selectors and optimizes the util functions.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

For detailed perf improvement results, see the details in PR #30958

TESTING INSTRUCTIONS

No functional changes - the dashboard, native filters, cross filters, chart actions, etc. should work like before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje merged commit ce0e06a into apache:master Dec 2, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:cross-filters Related to the Dashboard cross filters dashboard:native-filters Related to the native filters of the Dashboard dashboard:performance Related to Dashboard performance size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants