Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Go/Python version as an explicit input #17

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

webbnh
Copy link
Contributor

@webbnh webbnh commented Apr 10, 2024

Changes introduced with this PR

This PR modifies go_lint_and_test.yaml, go_release.yaml, and python_release.yaml to access the required version of Go or Python from the workflow inputs instead of trying to obtain it from a global variable. Access to variables has proved unreliable when executing workflows from PRs from forks. Also, making the values be explicit inputs instead better encapsulates and properly decouples the reusable workflows from the calling workflows and organizations.


By contributing to this repository, I agree to the contribution guidelines.

Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how does this all fit together? Can the individual workflows that call these still pull a single global organization-wide Go Version, or does each repo need to define its own?

@webbnh
Copy link
Contributor Author

webbnh commented Apr 10, 2024

So how does this all fit together? Can the individual workflows that call these still pull a single global organization-wide Go Version, or does each repo need to define its own?

The "flow" is as follows:

  1. At the Organization level, we define "variables" with the preferred versions of Go, Python, etc.
    • These can still be overridden at the repository or individual workflow level, if needed
  2. These variables are referenced in the repositories' build workflows in the invocations of the reusable workflows
  3. The subworkflows receive the version values as inputs.

See arcalot/arcaflow-engine#169 for an example.

@webbnh webbnh merged commit 7bb8ae2 into arcalot:main Apr 10, 2024
@webbnh webbnh deleted the use_inputs branch April 10, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants