feat: add new pointcloud format #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
mozhoku
added
the
type:new-feature
|
Could you fix the precommit errors? |
Signed-off-by: A. Sena Yılmaz <[email protected]>
Signed-off-by: A. Sena Yılmaz <[email protected]>
mozhoku
requested changes
Jul 24, 2024
mozhoku
approved these changes
Jul 24, 2024
|
It works with autoware-universe/main LGTM 👍 |
xmfcx
reviewed
Oct 28, 2024
Comment on lines
+71
to
+72
| RGLField.ELEVATION_F32, | ||
| RGLField.AZIMUTH_F32, |
There was a problem hiding this comment.
Order of these 2 lines should be changed.
xmfcx
reviewed
Oct 28, 2024
| RGLField.TIME_STAMP_F64 | ||
| }}, | ||
| // PointXYZIRCEADT format used by Autoware | ||
| {PointCloudFormat.PointXYZIRCEADT, new[] |
xmfcx
reviewed
Oct 28, 2024
| { | ||
| Pcl24, | ||
| Pcl48, | ||
| PointXYZIRCEADT, |
There was a problem hiding this comment.
This too needs to be changed to PointXYZIRCAEDT
xmfcx
reviewed
Oct 28, 2024
| { | ||
| topic = "lidar/pointcloud_ex", | ||
| publish = true, | ||
| fieldsPreset = PointCloudFormat.PointXYZIRCEADT, |
There was a problem hiding this comment.
This needs to be changed to PointXYZIRCAEDT
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After updating the RobotecRGLLidar library, I've added the updated library and new script by cherry-picking from (@msz-rai) the PR (tier4#334) opened in the TierIV AWSIM repo.
I tried with Autoware main branch and there is no problem with localization.
Related links
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.