-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): define hysteresis_factor_expand_rate #5002
Merged
kyoichi-sugahara
merged 6 commits into
autowarefoundation:main
from
kyoichi-sugahara:fix/define_hysteresis_factor_expand_rate
Sep 16, 2023
Merged
fix(behavior_path_planner): define hysteresis_factor_expand_rate #5002
kyoichi-sugahara
merged 6 commits into
autowarefoundation:main
from
kyoichi-sugahara:fix/define_hysteresis_factor_expand_rate
Sep 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <[email protected]>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Sep 14, 2023
Signed-off-by: kyoichi-sugahara <[email protected]>
4 tasks
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
September 15, 2023 04:57
kosuke55
approved these changes
Sep 15, 2023
kosuke55
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Sep 15, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5002 +/- ##
==========================================
- Coverage 15.74% 15.74% -0.01%
==========================================
Files 1587 1587
Lines 109828 109832 +4
Branches 33718 33722 +4
==========================================
Hits 17290 17290
Misses 73908 73908
- Partials 18630 18634 +4
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
merged commit Sep 16, 2023
67eae01
into
autowarefoundation:main
19 of 23 checks passed
kyoichi-sugahara
deleted the
fix/define_hysteresis_factor_expand_rate
branch
September 16, 2023 09:18
kyoichi-sugahara
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 18, 2023
…owarefoundation#5002) * define hysteresis_factor_expand_rate Signed-off-by: kyoichi-sugahara <[email protected]> * add hysteresis_factor_expand_rate in SafetyCheckParams Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * revert unnecessary change Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
kyoichi-sugahara
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 19, 2023
…owarefoundation#5002) * define hysteresis_factor_expand_rate Signed-off-by: kyoichi-sugahara <[email protected]> * add hysteresis_factor_expand_rate in SafetyCheckParams Signed-off-by: kyoichi-sugahara <[email protected]> * style(pre-commit): autofix * revert unnecessary change Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parameter of
hysteresis_factor_expand_rate
failed to be initialized.Fix this problem and add hysteresis_factor_expand_rate in SafetyCheckParams.
This PR should be merged first.
Tests performed
run psim
confirmed
hysteresis_factor_expand_rate
is sucessfully assigned.And start_planner doesn't die.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.