Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): define hysteresis_factor_expand_rate #5002

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Sep 14, 2023

Description

Parameter of hysteresis_factor_expand_rate failed to be initialized.
Fix this problem and add hysteresis_factor_expand_rate in SafetyCheckParams.

This PR should be merged first.

Tests performed

run psim

confirmed hysteresis_factor_expand_rate is sucessfully assigned.
And start_planner doesn't die.
image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 14, 2023
Signed-off-by: kyoichi-sugahara <[email protected]>
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (5b40aa5) 15.74% compared to head (982b0be) 15.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5002      +/-   ##
==========================================
- Coverage   15.74%   15.74%   -0.01%     
==========================================
  Files        1587     1587              
  Lines      109828   109832       +4     
  Branches    33718    33722       +4     
==========================================
  Hits        17290    17290              
  Misses      73908    73908              
- Partials    18630    18634       +4     
Flag Coverage Δ *Carryforward flag
differential 17.78% <0.00%> (?)
total 15.74% <ø> (+<0.01%) ⬆️ Carriedforward from 5b40aa5

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
..._safety_checker/path_safety_checker_parameters.hpp 50.00% <ø> (ø)
..._planner/src/scene_module/goal_planner/manager.cpp 5.17% <0.00%> (-0.05%) ⬇️
...planner/src/scene_module/start_planner/manager.cpp 4.44% <0.00%> (-0.04%) ⬇️
...cene_module/start_planner/start_planner_module.cpp 29.86% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 67eae01 into autowarefoundation:main Sep 16, 2023
19 of 23 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the fix/define_hysteresis_factor_expand_rate branch September 16, 2023 09:18
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Sep 18, 2023
…owarefoundation#5002)

* define hysteresis_factor_expand_rate

Signed-off-by: kyoichi-sugahara <[email protected]>

* add hysteresis_factor_expand_rate in SafetyCheckParams

Signed-off-by: kyoichi-sugahara <[email protected]>

* style(pre-commit): autofix

* revert unnecessary change

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Sep 19, 2023
…owarefoundation#5002)

* define hysteresis_factor_expand_rate

Signed-off-by: kyoichi-sugahara <[email protected]>

* add hysteresis_factor_expand_rate in SafetyCheckParams

Signed-off-by: kyoichi-sugahara <[email protected]>

* style(pre-commit): autofix

* revert unnecessary change

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants