-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): ensure temporal stop before peeking into oncoming lane #5047
Merged
soblin
merged 2 commits into
autowarefoundation:main
from
soblin:feat/intersection/ensure-temporal-stop-before-upcoming-lane
Sep 25, 2023
Merged
feat(intersection): ensure temporal stop before peeking into oncoming lane #5047
soblin
merged 2 commits into
autowarefoundation:main
from
soblin:feat/intersection/ensure-temporal-stop-before-upcoming-lane
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Sep 20, 2023
soblin
force-pushed
the
feat/intersection/ensure-temporal-stop-before-upcoming-lane
branch
2 times, most recently
from
September 20, 2023 09:55
0402fa3
to
b223ffe
Compare
soblin
requested review from
shmpwk,
takayuki5168 and
tkimura4
as code owners
September 20, 2023 10:29
soblin
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Sep 20, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5047 +/- ##
==========================================
- Coverage 15.00% 14.99% -0.01%
==========================================
Files 1608 1608
Lines 111744 111726 -18
Branches 34663 34657 -6
==========================================
- Hits 16762 16750 -12
- Misses 76259 76260 +1
+ Partials 18723 18716 -7
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
feat/intersection/ensure-temporal-stop-before-upcoming-lane
branch
from
September 25, 2023 09:00
b223ffe
to
cbf456b
Compare
takayuki5168
approved these changes
Sep 25, 2023
soblin
deleted the
feat/intersection/ensure-temporal-stop-before-upcoming-lane
branch
September 25, 2023 14:31
soblin
added a commit
to soblin/autoware.universe
that referenced
this pull request
Sep 26, 2023
… lane (autowarefoundation#5047) Signed-off-by: Mamoru Sobue <[email protected]>
7 tasks
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 5, 2023
… lane (autowarefoundation#5047) Signed-off-by: Mamoru Sobue <[email protected]>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 8, 2023
… lane (autowarefoundation#5047) Signed-off-by: Mamoru Sobue <[email protected]>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 11, 2023
… lane (autowarefoundation#5047) Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the option to stop before vehicle heading enters the oncoming lane when peeking offset is positive.
Related links
launcher PR: autowarefoundation/autoware_launch#578
https://tier4.atlassian.net/browse/RT1-3284
Tests performed
Psim
PR5047-2023-09-20_19.09.54.mp4
Notes for reviewers
This PR is off by default.
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.