Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): ensure temporal stop before peeking into oncoming lane #5047

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 20, 2023

Description

Added the option to stop before vehicle heading enters the oncoming lane when peeking offset is positive.

Related links

launcher PR: autowarefoundation/autoware_launch#578

https://tier4.atlassian.net/browse/RT1-3284

Tests performed

Psim

PR5047-2023-09-20_19.09.54.mp4

Notes for reviewers

This PR is off by default.

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 20, 2023
@soblin soblin force-pushed the feat/intersection/ensure-temporal-stop-before-upcoming-lane branch 2 times, most recently from 0402fa3 to b223ffe Compare September 20, 2023 09:55
@soblin soblin marked this pull request as ready for review September 20, 2023 10:29
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (7f98ecf) 15.00% compared to head (cbf456b) 14.99%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5047      +/-   ##
==========================================
- Coverage   15.00%   14.99%   -0.01%     
==========================================
  Files        1608     1608              
  Lines      111744   111726      -18     
  Branches    34663    34657       -6     
==========================================
- Hits        16762    16750      -12     
- Misses      76259    76260       +1     
+ Partials    18723    18716       -7     
Flag Coverage Δ *Carryforward flag
differential 6.66% <0.00%> (?)
total 14.99% <ø> (-0.01%) ⬇️ Carriedforward from 7f98ecf

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ils/include/motion_utils/trajectory/trajectory.hpp 67.09% <ø> (+0.06%) ⬆️
...planning_rviz_plugin/include/path/display_base.hpp 0.00% <ø> (ø)
...clude/behavior_path_planner/marker_utils/utils.hpp 0.00% <ø> (ø)
...th_planner/scene_module/lane_change/base_class.hpp 15.55% <ø> (ø)
..._safety_checker/path_safety_checker_parameters.hpp 33.33% <ø> (ø)
...ath_planner/src/marker_utils/lane_change/debug.cpp 0.00% <ø> (ø)
...g/behavior_path_planner/src/marker_utils/utils.cpp 6.05% <ø> (ø)
...planner/src/scene_module/lane_change/interface.cpp 6.52% <ø> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 3.77% <ø> (ø)
...planner/src/utils/goal_planner/shift_pull_over.cpp 3.57% <ø> (+0.03%) ⬆️
... and 11 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin force-pushed the feat/intersection/ensure-temporal-stop-before-upcoming-lane branch from b223ffe to cbf456b Compare September 25, 2023 09:00
@soblin soblin merged commit 9e4b4e9 into autowarefoundation:main Sep 25, 2023
19 of 24 checks passed
@soblin soblin deleted the feat/intersection/ensure-temporal-stop-before-upcoming-lane branch September 25, 2023 14:31
soblin added a commit to soblin/autoware.universe that referenced this pull request Sep 26, 2023
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 5, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 8, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants