Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start/goal_planner): resample path and make params #5085

Merged
merged 3 commits into from
Sep 24, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 22, 2023

Description

resample freespace pull out path to fix sparse drivable area.
and make params for resaple reference center line path interval

(the drivable area is out of lane but it will be fixed after start planner is finished at end pose in freespace area)

before

image

after

image

Related links

Tests performed

psim

2023/09/22 https://evaluation.tier4.jp/evaluation/reports/8252efaa-a564-5b45-a8bb-91fde156e462/?project_id=prd_jt

https://evaluation.tier4.jp/evaluation/reports/72bd5eb6-8f81-5a7f-98a1-caa6381c510b?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Sep 22, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 9.37% and project coverage change: -0.01% ⚠️

Comparison is base (1911464) 15.02% compared to head (f997457) 15.02%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5085      +/-   ##
==========================================
- Coverage   15.02%   15.02%   -0.01%     
==========================================
  Files        1608     1608              
  Lines      111713   111730      +17     
  Branches    34631    34640       +9     
==========================================
- Hits        16787    16786       -1     
- Misses      76226    76235       +9     
- Partials    18700    18709       +9     
Flag Coverage Δ *Carryforward flag
differential 12.61% <9.37%> (?)
total 15.02% <ø> (-0.01%) ⬇️ Carriedforward from 5de5125

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ic_parallel_parking/geometric_parallel_parking.hpp 16.66% <ø> (ø)
...ath_planner/utils/goal_planner/shift_pull_over.hpp 0.00% <ø> (ø)
...ath_planner/utils/start_planner/shift_pull_out.hpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.cpp 5.35% <0.00%> (-0.01%) ⬇️
...ic_parallel_parking/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
...planner/src/utils/goal_planner/shift_pull_over.cpp 3.53% <0.00%> (ø)
...ner/src/utils/start_planner/freespace_pull_out.cpp 14.00% <0.00%> (-0.59%) ⬇️
...planner/src/utils/start_planner/shift_pull_out.cpp 2.48% <0.00%> (-0.05%) ⬇️
..._planner/src/scene_module/goal_planner/manager.cpp 5.79% <20.00%> (+0.27%) ⬆️
...planner/src/scene_module/start_planner/manager.cpp 5.57% <66.66%> (+0.79%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the fix/resample_start_goal_planner branch from 385f9e0 to 5de5125 Compare September 23, 2023 08:06
@kosuke55
Copy link
Contributor Author

kosuke55 commented Sep 24, 2023

@kyoichi-sugahara
thanks! could you please approve autowarefoundation/autoware_launch#586 ?

@kyoichi-sugahara
Copy link
Contributor

@kosuke55
Oh sorry.
Approved now.

@kosuke55 kosuke55 merged commit a4c94cc into main Sep 24, 2023
@kosuke55 kosuke55 deleted the fix/resample_start_goal_planner branch September 24, 2023 09:07
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Oct 3, 2023
…ation#5085)

* chore(geometric_parallel_parking): remove unused parames and initialize variables

Signed-off-by: kosuke55 <[email protected]>

* fix(start/goal_planner): resample path and make params

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Co-authored-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants