refactor(control): Remove unused variables and functions #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brkay54
added
the
component:control
github-actions
bot
added
the
type:documentation
brkay54
force-pushed
the
feat/remove-old-streering-checking
branch
3 times, most recently
from
505b773 to
f343270
Compare
Closed
4 tasks
4 tasks
brkay54
force-pushed
the
feat/remove-old-streering-checking
branch
3 times, most recently
from
ff8e5bf to
25e3863
Compare
7 tasks
brkay54
force-pushed
the
feat/remove-old-streering-checking
branch
from
25e3863 to
a0fcde3
Compare
…ped state Signed-off-by: Berkay Karaman <[email protected]>
Signed-off-by: Berkay Karaman <[email protected]>
brkay54
force-pushed
the
feat/remove-old-streering-checking
branch
from
a0fcde3 to
5979dfa
Compare
|
Closed because of the latest discussions in main PR: #5183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit removes the
converged_steer_radvariable and theisSteerConverged()function from the related packages to move the functionality tovehicle_cmd_gate. These were not being used in the codebase.Update in launch file -> autowarefoundation/autoware_launch#616
Related links
#5183
#4915
Tests performed
Tested in pSim and worked well.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.