-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): configurable object type for safety check #5699
Merged
satoshi-ota
merged 1 commit into
autowarefoundation:main
from
satoshi-ota:feat/ignore-unknown-safety-check
Nov 28, 2023
Merged
feat(avoidance): configurable object type for safety check #5699
satoshi-ota
merged 1 commit into
autowarefoundation:main
from
satoshi-ota:feat/ignore-unknown-safety-check
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <[email protected]>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Nov 28, 2023
Merged
5 tasks
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
soblin,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4 and
zulfaqar-azmi-t4
as code owners
November 28, 2023 07:16
satoshi-ota
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 28, 2023
shmpwk
approved these changes
Nov 28, 2023
shmpwk
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 29, 2023
…oundation#5699) Signed-off-by: satoshi-ota <[email protected]>
Merged
4 tasks
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 30, 2023
…oundation#5699) (#1046) Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Dec 1, 2023
…oundation#5699) Signed-off-by: satoshi-ota <[email protected]>
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…oundation#5699) Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖[deprecated] Generated by Copilot at 7ddc64c
This pull request refactors the behavior path planner module to use a new
target_type
parameter group for filtering predicted objects by their type for avoidance and safety check. It removes theis_target
parameter from various files and adds new fields and functions to theavoidance_module_data.hpp
andutils.cpp
files. It also simplifies and unifies the scene module interface and configuration.Related PR: autowarefoundation/autoware_launch#709
Related Ticket: https://tier4.atlassian.net/browse/RT1-4126
Add new parameter so that it can configurate target object type for safety check. Additionally, it ignores UNKNOWN objects in safety check process because UNKNOWN objects detection is unstable and causes unnecessary avoidance canceling for now.
Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.