Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): configurable object type for safety check #5699

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 28, 2023

Description

🤖[deprecated] Generated by Copilot at 7ddc64c

This pull request refactors the behavior path planner module to use a new target_type parameter group for filtering predicted objects by their type for avoidance and safety check. It removes the is_target parameter from various files and adds new fields and functions to the avoidance_module_data.hpp and utils.cpp files. It also simplifies and unifies the scene module interface and configuration.

Related PR: autowarefoundation/autoware_launch#709
Related Ticket: https://tier4.atlassian.net/browse/RT1-4126


Add new parameter so that it can configurate target object type for safety check. Additionally, it ignores UNKNOWN objects in safety check process because UNKNOWN objects detection is unstable and causes unnecessary avoidance canceling for now.

      # For safety check
      safety_check:
        # safety check target type
        target_type:
          car: true                                      # [-]
          truck: true                                    # [-]
          bus: true                                      # [-]
          trailer: true                                  # [-]
          unknown: false                                 # [-]
          bicycle: true                                  # [-]
          motorcycle: true                               # [-]
          pedestrian: true                               # [-]

image

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 28, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review November 28, 2023 07:16
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 2199 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (7ddc64c) 12.73%.
Report is 86 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 13.19% 597 Missing and 87 partials ⚠️
...anner/src/utils/avoidance/shift_line_generator.cpp 13.28% 431 Missing and 65 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.90% 187 Missing and 10 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.56% 175 Missing and 2 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 10.56% 110 Missing and 17 partials ⚠️
...ner/src/utils/path_safety_checker/safety_check.cpp 0.00% 84 Missing ⚠️
..._path_planner/src/marker_utils/avoidance/debug.cpp 0.00% 61 Missing ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 1.81% 54 Missing ⚠️
...cene_module/start_planner/start_planner_module.cpp 8.62% 53 Missing ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
... and 22 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5699       +/-   ##
===========================================
- Coverage   15.32%   12.73%    -2.59%     
===========================================
  Files        1721      110     -1611     
  Lines      118559    15238   -103321     
  Branches    37995     8511    -29484     
===========================================
- Hits        18169     1941    -16228     
+ Misses      79657    10283    -69374     
+ Partials    20733     3014    -17719     
Flag Coverage Δ
differential 12.73% <12.11%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 5d9f3ac into autowarefoundation:main Nov 28, 2023
46 of 50 checks passed
@satoshi-ota satoshi-ota deleted the feat/ignore-unknown-safety-check branch November 28, 2023 10:29
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Nov 29, 2023
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2023
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Dec 1, 2023
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants