Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(topic_state_monitor): rework parameters #5731

Closed

Conversation

karishma1911
Copy link
Contributor

@karishma1911 karishma1911 commented Nov 30, 2023

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the topic_state_monitor

  1. Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
  2. create schema

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Nov 30, 2023
Copy link

stale bot commented Mar 19, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 19, 2024
@idorobotics
Copy link

@mitsudome-r please urgently review.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label May 24, 2024
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 24, 2024
@xmfcx xmfcx closed this May 24, 2024
@xmfcx xmfcx reopened this May 24, 2024
@xmfcx xmfcx changed the title refactor(system/topic_state_monitor): rework parameters refactor(topic_state_monitor): rework parameters May 24, 2024
@xmfcx
Copy link
Contributor

xmfcx commented May 24, 2024

@karishma1911 could you rebase this to the latest main? To fix the CI.

Or click Allow edits and access to secrets by maintainers. For this PR. So we can do it for you.

@idorobotics
Copy link

@mitsudome-r could you urgently review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants