-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(topic_state_monitor): rework parameters #5731
Closed
karishma1911
wants to merge
11
commits into
autowarefoundation:main
from
Interplai:topic-state-monitor
Closed
refactor(topic_state_monitor): rework parameters #5731
karishma1911
wants to merge
11
commits into
autowarefoundation:main
from
Interplai:topic-state-monitor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:system
System design and integration. (auto-assigned)
label
Nov 30, 2023
Signed-off-by: karishma <[email protected]>
karishma1911
force-pushed
the
topic-state-monitor
branch
from
November 30, 2023 10:03
9370233
to
2bf7cf9
Compare
Signed-off-by: karishma <[email protected]>
karishma1911
force-pushed
the
topic-state-monitor
branch
from
November 30, 2023 13:26
4106693
to
7f3e7e8
Compare
This pull request has been automatically marked as stale because it has not had recent activity. |
@mitsudome-r please urgently review. |
xmfcx
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
May 24, 2024
xmfcx
changed the title
refactor(system/topic_state_monitor): rework parameters
refactor(topic_state_monitor): rework parameters
May 24, 2024
@karishma1911 could you rebase this to the latest main? To fix the CI. Or click Allow edits and access to secrets by maintainers. For this PR. So we can do it for you. |
@mitsudome-r could you urgently review this PR? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:system
System design and integration. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the topic_state_monitor
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.