refactor(perception_ground_segmentation): rework parameters #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karishma1911
requested review from
amc-nu,
badai-nguyen,
miursh and
yukkysaito
as code owners
github-actions
bot
added
the
component:perception
karishma1911
force-pushed
the
ground-segmentation
branch
from
ffe3aa4 to
f0e842a
Compare
karishma1911
changed the title
karishma1911
changed the title
karishma1911
force-pushed
the
ground-segmentation
branch
3 times, most recently
from
615a8f0 to
402a714
Compare
badai-nguyen
requested changes
Dec 7, 2023
There was a problem hiding this comment.
@karishma1911 Thank you for you PR,
IMO: since all default parameters of 3 filters will be removed, then those default parameters should be listed somewhere like xx_ground_filter.param.yaml in config/. Otherwise the current launch for specific scan_ground_filter (scan_ground_filter.launch.py) cannot be executed.
We are sorry that default launch.py for remaining ransac_ground_filter and ray_ground_filter was not maintained well yet.
perception/ground_segmentation/src/ray_ground_filter_nodelet.cpp
Outdated
Show resolved
Hide resolved
perception/ground_segmentation/src/ransac_ground_filter_nodelet.cpp
Outdated
Show resolved
Hide resolved
karishma1911
force-pushed
the
ground-segmentation
branch
from
0b05ec4 to
fd51aa9
Compare
karishma1911
force-pushed
the
ground-segmentation
branch
from
cf9a28f to
930ab55
Compare
karishma1911
requested review from
kosuke55,
satoshi-ota,
takayuki5168,
shmpwk,
tkimura4,
mkuri,
TomohitoAndo,
kyoichi-sugahara,
soblin,
rej55,
TakaHoribe,
zulfaqar-azmi-t4 and
taikitanaka3
as code owners
github-actions
bot
added
component:planning
karishma1911
requested review from
Shin-kyoto,
ktro2828,
knzo25,
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
IshitaTakeshi,
h-ohta,
KhalilSelyan and
1222-takeshi
as code owners
github-actions
bot
added
type:documentation
|
@karishma1911 Please fix the PR or recreate as another one 🙏 |
|
@karishma1911 Let me convert this PR as a draft as it may be noisy for other developers. But feel free to reopen this PR once it is fixed. Thank you for your contribution! |
|
I'll close this PR for now, as it doesn't appear to be actively progressing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the perception_ground_segmentation
2.create schema
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.