Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(probabilistic_occupancy_grid_map): move header files to the probabilistic_occupancy_grid_map folder to avoid conflicts #5839

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Dec 11, 2023

Description

Move header files to its own directory to avoid conflicts.

See #5826
See autowarefoundation/autoware#4070

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 11, 2023
@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73c9e17) 15.21% compared to head (94f6fdf) 15.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5839   +/-   ##
=======================================
  Coverage   15.21%   15.22%           
=======================================
  Files        1767     1773    +6     
  Lines      121754   121786   +32     
  Branches    37054    37061    +7     
=======================================
+ Hits        18526    18540   +14     
- Misses      82407    82422   +15     
- Partials    20821    20824    +3     
Flag Coverage Δ *Carryforward flag
differential 27.56% <ø> (?)
total 15.21% <ø> (ø) Carriedforward from 73c9e17

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve enabled auto-merge (squash) December 14, 2023 14:50
@esteve esteve marked this pull request as draft January 9, 2024 12:02
auto-merge was automatically disabled January 9, 2024 12:02

Pull request was converted to draft

@esteve esteve force-pushed the probabilistic-occupancy-grid-map-move-utils branch from c715e6c to 2f74a7e Compare January 9, 2024 12:14
@esteve esteve marked this pull request as ready for review January 9, 2024 12:17
@esteve esteve enabled auto-merge (squash) January 9, 2024 12:18
@esteve esteve force-pushed the probabilistic-occupancy-grid-map-move-utils branch from a1ea379 to 3c3e552 Compare January 9, 2024 12:20
@esteve esteve marked this pull request as draft January 11, 2024 12:28
auto-merge was automatically disabled January 11, 2024 12:28

Pull request was converted to draft

@esteve esteve force-pushed the probabilistic-occupancy-grid-map-move-utils branch from 3c3e552 to d7663cf Compare January 11, 2024 12:37
…babilistic_occupancy_grid_map folder to avoid conflicts

Signed-off-by: Esteve Fernandez <[email protected]>
@esteve esteve force-pushed the probabilistic-occupancy-grid-map-move-utils branch from d7663cf to cd3c864 Compare January 11, 2024 13:51
@esteve esteve marked this pull request as ready for review January 11, 2024 14:53
@esteve esteve enabled auto-merge (squash) January 11, 2024 14:53
@esteve
Copy link
Contributor Author

esteve commented Jan 11, 2024

@soblin @YoshiRi @yukkysaito @xmfcx @mitsudome-r this is now ready for review, please have a look when you're available. Thanks 🙂

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve merged commit 068f589 into autowarefoundation:main Jan 12, 2024
22 of 24 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…babilistic_occupancy_grid_map folder to avoid conflicts (autowarefoundation#5839)

* build(probabilistic_occupancy_grid_map): move header files to the probabilistic_occupancy_grid_map folder to avoid conflicts

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…babilistic_occupancy_grid_map folder to avoid conflicts (autowarefoundation#5839)

* build(probabilistic_occupancy_grid_map): move header files to the probabilistic_occupancy_grid_map folder to avoid conflicts

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…babilistic_occupancy_grid_map folder to avoid conflicts (autowarefoundation#5839)

* build(probabilistic_occupancy_grid_map): move header files to the probabilistic_occupancy_grid_map folder to avoid conflicts

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…babilistic_occupancy_grid_map folder to avoid conflicts (autowarefoundation#5839)

* build(probabilistic_occupancy_grid_map): move header files to the probabilistic_occupancy_grid_map folder to avoid conflicts

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants