-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(obstacle_avoidance_planner): use update_bounds instead of update_lower/upper_bounds #6011
Merged
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:fix/mpt-update-bounds
Jan 5, 2024
Merged
fix(obstacle_avoidance_planner): use update_bounds instead of update_lower/upper_bounds #6011
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:fix/mpt-update-bounds
Jan 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lower/upper_bounds Signed-off-by: Takayuki Murooka <[email protected]>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jan 4, 2024
takayuki5168
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 4, 2024
4 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6011 +/- ##
=======================================
Coverage 15.22% 15.22%
=======================================
Files 1751 1751
Lines 120849 120848 -1
Branches 36721 36720 -1
=======================================
Hits 18398 18398
+ Misses 81810 81809 -1
Partials 20641 20641
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yuki-takagi-66
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 5, 2024
…lower/upper_bounds (autowarefoundation#6011) Signed-off-by: Takayuki Murooka <[email protected]>
4 tasks
yuki-takagi-66
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 12, 2024
…lower/upper_bounds (autowarefoundation#6011) Signed-off-by: Takayuki Murooka <[email protected]>
4 tasks
saka1-s
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 12, 2024
…lower/upper_bounds (autowarefoundation#6011) (#1253) Signed-off-by: Takayuki Murooka <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…lower/upper_bounds (autowarefoundation#6011) Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…lower/upper_bounds (autowarefoundation#6011) Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…lower/upper_bounds (autowarefoundation#6011) Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…lower/upper_bounds (autowarefoundation#6011) Signed-off-by: Takayuki Murooka <[email protected]>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 2, 2024
…lower/upper_bounds (autowarefoundation#6011) Signed-off-by: Takayuki Murooka <[email protected]>
Merged
4 tasks
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 2, 2024
#1371) fix(obstacle_avoidance_planner): use update_bounds instead of update_lower/upper_bounds (autowarefoundation#6011) Signed-off-by: Takayuki Murooka <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]>
zhiwango
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 9, 2024
#1371) fix(obstacle_avoidance_planner): use update_bounds instead of update_lower/upper_bounds (autowarefoundation#6011) Signed-off-by: Takayuki Murooka <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updating the bounds of QP with a warm start in the obstacle_avoidance_planner package, this PR uses
osqp_update_bounds
instead ofosqp_update_lower/upper_bound
.According to the OSQP's implementation, the condition of whether the lower bound is smaller than the upper bound is checked in each
osqp_upper_lower/upper_bound
function.Without this PR, since the lower and upper bounds are updated separately, when the lower bound is updated but the upper bound is not updated, the condition may not be met, resulting in the following printing many times.
In addition, in the latest version of OSQP's implementation,
osqp_update_lower/upper_bound
will be removed.osqp/osqp#192
Tests performed
psim
Effects on system behavior
nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.