chore(pointcloud_container): move glog_component to autoware_launch #6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <[email protected]>
github-actions
bot
added
the
component:launch
kminoda
added
the
run:build-and-test-differential
|
@badai-nguyen Hi, do you mind checking this PR as well as autowarefoundation/autoware_launch#805? Related to #5716 |
4 tasks
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 23, 2024
kminoda
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 2, 2024
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move glog declaration for pointcloud_container in autoware_launch, where the container is launched.
MUST BE MERGED WITH autowarefoundation/autoware_launch#805
Tests performed
Checked that glog_component is included in pointcloud_container with
ros2 component list.Effects on system behavior
No effect expected
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.