-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pointcloud_container): move glog_component to autoware_launch #805
chore(pointcloud_container): move glog_component to autoware_launch #805
Conversation
Signed-off-by: kminoda <[email protected]>
@kminoda 1 /perception/object_recognition/detection/voxel_grid_downsample_filter after: 1 /sensing/lidar/concatenate_data |
Signed-off-by: kminoda <[email protected]>
@badai-nguyen Right, thank you for the comment. Fixed: 278988d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Move glog declaration for
pointcloud_container
in autoware_launch, where the container is launched.Tests performed
see autowarefoundation/autoware.universe#6114
Effects on system behavior
No effect expected
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.