Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pointcloud_container): move glog_component to autoware_launch #805

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 19, 2024

Description

Move glog declaration for pointcloud_container in autoware_launch, where the container is launched.

Tests performed

see autowarefoundation/autoware.universe#6114

Effects on system behavior

No effect expected

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen
Copy link
Contributor

badai-nguyen commented Jan 19, 2024

@kminoda
Since glog_component has no namespace after changing, another glog use should pay more attention to avoid name confict. Do you think is better to add namespace for it?
before:
`/pointcloud_container

1 /perception/object_recognition/detection/voxel_grid_downsample_filter
2 /sensing/lidar/concatenate_data
3 /perception/obstacle_segmentation/glog_component
4 /perception/occupancy_grid_map/occupancy_grid_map_node
5 /perception/object_recognition/detection/voxel_based_compare_map_filter
6 /perception/obstacle_segmentation/crop_box_filter
7 /perception/obstacle_segmentation/common_ground_filter
8 /perception/obstacle_segmentation/occupancy_grid_map_outlier_filter
`

after:
`/pointcloud_container

1 /sensing/lidar/concatenate_data
2 /glog_component
3 /perception/object_recognition/detection/voxel_grid_downsample_filter
4 /perception/obstacle_segmentation/crop_box_filter
5 /perception/occupancy_grid_map/occupancy_grid_map_node
6 /perception/object_recognition/detection/voxel_based_compare_map_filter
7 /perception/obstacle_segmentation/common_ground_filter
8 /perception/obstacle_segmentation/occupancy_grid_map_outlier_filter
`

@kminoda
Copy link
Contributor Author

kminoda commented Jan 19, 2024

@badai-nguyen Right, thank you for the comment. Fixed: 278988d

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 765cafd into autowarefoundation:main Jan 20, 2024
9 of 10 checks passed
@kminoda kminoda deleted the chore/pointcloud_container/move_glog branch February 2, 2024 07:00
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Apr 8, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants