fix: fix schema json in planning/vehicle #6456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
requested review from
mkuri,
taikitanaka3,
TakaHoribe,
kosuke55,
kyoichi-sugahara,
soblin,
maxime-clem,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
component:planning
takayuki5168
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6456 +/- ##
=======================================
Coverage 15.13% 15.13%
=======================================
Files 1819 1819
Lines 126026 126026
Branches 38188 38188
=======================================
Hits 19075 19075
Misses 85563 85563
Partials 21388 21388
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
xmfcx
reviewed
Feb 22, 2024
Comment on lines
-145
to
-147
| "csv_path_accel_map", | ||
| "csv_path_brake_map", | ||
| "csv_path_steer_map", |
There was a problem hiding this comment.
Instead of removing these lines, I focused on fixing the source of the problem.
4 tasks
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Takayuki Murooka <[email protected]>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the obsolete schema json files in planning/vehicle
Tests performed
json-schema-check / json-schema-check (pull_request)has no errors for planning/vehicle.Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.