fix(raw_vehicle_cmd_converter): csv paths are resolved in param.yaml

[xmfcx]

Description

Part of:

• Fix json-schema-check errors and make the workflow required #6473

Continuation of:

• fix: fix schema json in planning/vehicle #6456
• fix(raw_vehicle_cmd_converter): fix parameter files to parse path to csv files #6136
• refactor(raw_vehicle_cmd_converter): rework parameters #5134

Related PR:

• fix(raw_vehicle_cmd_converter): csv paths are resolved in param.yaml autoware_launch#884
  • autoware_launch PR should be merged after this PR.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[xmfcx]

@rej55 from:

• fix(raw_vehicle_cmd_converter): fix parameter files to parse path to csv files #6136

However, if we launch raw_vehicle_cmd_converter from autoware_launch, some parameters defined in launch files does not appear.

In this change, I fixed above problems.

accel/brake/steer map path should change at launch, so I removed csv_path_**_map from yaml file and add them into xml file.

What do you mean by this?

What is wrong with having things this way?

As long as we have this:

autoware.universe/vehicle/raw_vehicle_cmd_converter/launch/raw_vehicle_converter.launch.xml

Line 11 in 50bb613

<param from="$(var config_file)" allow_substs="true"/>

<param from="$(var config_file)" allow_substs="true"/> it should work alright.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.64%. Comparing base (fdd3f9e) to head (7ad4075).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6476   +/-   ##
=======================================
  Coverage   14.64%   14.64%           
=======================================
  Files        1899     1899           
  Lines      130283   130283           
  Branches    38311    38311           
=======================================
  Hits        19076    19076           
  Misses      89793    89793           
  Partials    21414    21414           

Flag	Coverage Δ		*Carryforward flag
differential	10.52% <ø> (?)
total	14.64% <ø> (ø)		Carriedforward from fdd3f9e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xmfcx]

@mkuri @taikitanaka3 @TakaHoribe could you review this as a code owner?
I would like to merge this as soon as possible and make the action required.

cc. @rej55

[xmfcx]

@rej55 could you look into this? I want to merge this.

[rej55]

@xmfcx
The change looks okay but we have to change some launch files in other repository.
I will change it in this week, so could you wait, please?

[xmfcx]

@rej55 It's alright, I am waiting for your updates 👍

[rej55]

I checked that it worked with this change.
LGTM