-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pointcloud_preprocessor): enable to change synchronized pointcloud topic name #6525
feat(pointcloud_preprocessor): enable to change synchronized pointcloud topic name #6525
Conversation
Signed-off-by: yoshiri <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Signed-off-by: yoshiri <[email protected]>
...essor/include/pointcloud_preprocessor/concatenate_data/concatenate_and_time_sync_nodelet.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: yoshiri <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6525 +/- ##
==========================================
- Coverage 15.09% 15.04% -0.06%
==========================================
Files 1823 1828 +5
Lines 126342 126793 +451
Branches 38200 38200
==========================================
Hits 19077 19077
- Misses 85871 86322 +451
Partials 21394 21394
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
thank you for accepting proposal
…ud topic name (autowarefoundation#6525) * feat: enable to change synchronized pointcloud message Signed-off-by: yoshiri <[email protected]> * fix: bug fix in topic name replace function Signed-off-by: yoshiri <[email protected]> * revert: revert changes do not related with this PR Signed-off-by: yoshiri <[email protected]> * chore: move topic rename function to class member Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
…ud topic name (autowarefoundation#6525) * feat: enable to change synchronized pointcloud message Signed-off-by: yoshiri <[email protected]> * fix: bug fix in topic name replace function Signed-off-by: yoshiri <[email protected]> * revert: revert changes do not related with this PR Signed-off-by: yoshiri <[email protected]> * chore: move topic rename function to class member Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
…ud topic name (#6525) * feat: enable to change synchronized pointcloud message Signed-off-by: yoshiri <[email protected]> * fix: bug fix in topic name replace function Signed-off-by: yoshiri <[email protected]> * revert: revert changes do not related with this PR Signed-off-by: yoshiri <[email protected]> * chore: move topic rename function to class member Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
…ud topic name (autowarefoundation#6525) * feat: enable to change synchronized pointcloud message Signed-off-by: yoshiri <[email protected]> * fix: bug fix in topic name replace function Signed-off-by: yoshiri <[email protected]> * revert: revert changes do not related with this PR Signed-off-by: yoshiri <[email protected]> * chore: move topic rename function to class member Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]> Signed-off-by: kaigohirao <[email protected]>
…ud topic name (autowarefoundation#6525) * feat: enable to change synchronized pointcloud message Signed-off-by: yoshiri <[email protected]> * fix: bug fix in topic name replace function Signed-off-by: yoshiri <[email protected]> * revert: revert changes do not related with this PR Signed-off-by: yoshiri <[email protected]> * chore: move topic rename function to class member Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
…ud topic name (autowarefoundation#6525) * feat: enable to change synchronized pointcloud message Signed-off-by: yoshiri <[email protected]> * fix: bug fix in topic name replace function Signed-off-by: yoshiri <[email protected]> * revert: revert changes do not related with this PR Signed-off-by: yoshiri <[email protected]> * chore: move topic rename function to class member Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
…ange synchronized pointcloud topic name (autowarefoundation#6525) fix : fix : fix conflict occured by cherry pick Signed-off-by: N-Eiki <[email protected]>
Description
This PR enables to
concatenate_node
ortime_sync_node
to publish any name.This feature is going to used in interface change:
https://github.com/orgs/autowarefoundation/discussions/4158
inner works
/sensing/lidar/sample/input_pointcloud
to/sensing/lidar/sample/<postfix>
synchronized_pointcloud_postfix
, we setpointcloud
as default as for the above discussionpointcloud
, the topic name replace function returns the same name, so we replace synchronized pointcloud name withpointcloud_synchronized
Related links
https://github.com/orgs/autowarefoundation/discussions/4158
Tests performed
Tested with Lsim with sample-rosbag
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.