Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointcloud_preprocessor): enable to change synchronized pointcloud topic name #6525

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Mar 1, 2024

Description

This PR enables to concatenate_node or time_sync_node to publish any name.
This feature is going to used in interface change:
https://github.com/orgs/autowarefoundation/discussions/4158

inner works

  • The topic rename function tries to rename input topic by replacing last part of the topic name
    • example: /sensing/lidar/sample/input_pointcloud to /sensing/lidar/sample/<postfix>
    • postfix is controlled by rosparam synchronized_pointcloud_postfix, we set pointcloud as default as for the above discussion
  • If the input topic end with pointcloud, the topic name replace function returns the same name, so we replace synchronized pointcloud name with pointcloud_synchronized

Related links

https://github.com/orgs/autowarefoundation/discussions/4158

Tests performed

Tested with Lsim with sample-rosbag

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Mar 1, 2024
@github-actions github-actions bot removed the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 1, 2024
@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 15.04%. Comparing base (86b4335) to head (6de7344).
Report is 49 commits behind head on main.

Files Patch % Lines
...atenate_data/concatenate_and_time_sync_nodelet.cpp 0.00% 11 Missing ⚠️
...rc/time_synchronizer/time_synchronizer_nodelet.cpp 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6525      +/-   ##
==========================================
- Coverage   15.09%   15.04%   -0.06%     
==========================================
  Files        1823     1828       +5     
  Lines      126342   126793     +451     
  Branches    38200    38200              
==========================================
  Hits        19077    19077              
- Misses      85871    86322     +451     
  Partials    21394    21394              
Flag Coverage Δ *Carryforward flag
differential 5.19% <0.00%> (?)
total 15.09% <ø> (+<0.01%) ⬆️ Carriedforward from 86b4335

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thank you for accepting proposal

@YoshiRi YoshiRi merged commit 44e4be7 into autowarefoundation:main Mar 2, 2024
32 of 34 checks passed
@YoshiRi YoshiRi deleted the feat/interface_change_in_pointcloud_concatenation branch March 4, 2024 07:44
YoshiRi added a commit to tier4/autoware.universe that referenced this pull request Mar 11, 2024
…ud topic name (autowarefoundation#6525)

* feat: enable to change synchronized pointcloud message

Signed-off-by: yoshiri <[email protected]>

* fix: bug fix in topic name replace function

Signed-off-by: yoshiri <[email protected]>

* revert: revert changes do not related with this PR

Signed-off-by: yoshiri <[email protected]>

* chore: move topic rename function to class member

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
YoshiRi added a commit to tier4/autoware.universe that referenced this pull request Mar 11, 2024
…ud topic name (autowarefoundation#6525)

* feat: enable to change synchronized pointcloud message

Signed-off-by: yoshiri <[email protected]>

* fix: bug fix in topic name replace function

Signed-off-by: yoshiri <[email protected]>

* revert: revert changes do not related with this PR

Signed-off-by: yoshiri <[email protected]>

* chore: move topic rename function to class member

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…ud topic name (#6525)

* feat: enable to change synchronized pointcloud message

Signed-off-by: yoshiri <[email protected]>

* fix: bug fix in topic name replace function

Signed-off-by: yoshiri <[email protected]>

* revert: revert changes do not related with this PR

Signed-off-by: yoshiri <[email protected]>

* chore: move topic rename function to class member

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…ud topic name (autowarefoundation#6525)

* feat: enable to change synchronized pointcloud message

Signed-off-by: yoshiri <[email protected]>

* fix: bug fix in topic name replace function

Signed-off-by: yoshiri <[email protected]>

* revert: revert changes do not related with this PR

Signed-off-by: yoshiri <[email protected]>

* chore: move topic rename function to class member

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: kaigohirao <[email protected]>
YoshiRi added a commit to tier4/autoware.universe that referenced this pull request May 10, 2024
…ud topic name (autowarefoundation#6525)

* feat: enable to change synchronized pointcloud message

Signed-off-by: yoshiri <[email protected]>

* fix: bug fix in topic name replace function

Signed-off-by: yoshiri <[email protected]>

* revert: revert changes do not related with this PR

Signed-off-by: yoshiri <[email protected]>

* chore: move topic rename function to class member

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ud topic name (autowarefoundation#6525)

* feat: enable to change synchronized pointcloud message

Signed-off-by: yoshiri <[email protected]>

* fix: bug fix in topic name replace function

Signed-off-by: yoshiri <[email protected]>

* revert: revert changes do not related with this PR

Signed-off-by: yoshiri <[email protected]>

* chore: move topic rename function to class member

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
N-Eiki pushed a commit to tier4/autoware.universe that referenced this pull request Jun 10, 2024
…ange synchronized pointcloud topic name (autowarefoundation#6525)

fix : fix : fix conflict occured by cherry pick
Signed-off-by: N-Eiki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants