refactor(autoware_test_utils): enhance makeMapBinMsg to accept package name and map filename parameters #9617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameters Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
requested review from
TakaHoribe,
soblin and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…Msg and related functions Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
added
the
tag:run-build-and-test-differential
soblin
approved these changes
Dec 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9617 +/- ##
==========================================
+ Coverage 29.54% 29.67% +0.13%
==========================================
Files 1443 1450 +7
Lines 108489 111341 +2852
Branches 41391 43226 +1835
==========================================
+ Hits 32055 33043 +988
- Misses 73323 75005 +1682
- Partials 3111 3293 +182
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
removed
the
tag:run-build-and-test-differential
kyoichi-sugahara
added
the
tag:run-build-and-test-differential
TakaHoribe
approved these changes
Dec 12, 2024
kyoichi-sugahara
merged commit 41ca768
into
autowarefoundation:main
44 of 46 checks passed
kyoichi-sugahara
deleted the
refactor/autoware_test_utils/specify_map_path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
makeMapBinMsgfunction to allow specifying custom package name and map filenamemakeMapBinMsgto reflect new parameterscreatePoseFromLaneIDandmakeBehaviorRouteFromLaneIdto support custom map loadingpackage_name="",map_filename="lanelet2_map.osm")This change is necessary to use a different map than the default one when calling the function
makeBehaviorRouteFromLaneIdto generate a route.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.