Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(control): use preset.yaml to control which modules to launch for control modules #1237

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

xtk8532704
Copy link
Contributor

@xtk8532704 xtk8532704 commented Nov 18, 2024

Description

Add control/preset.yaml to control which modules to launch for control modules just as how planning modules are launched.

Related links

autoware.universe PR: autowarefoundation/autoware.universe#9351

Tests performed

Psim, Evaluator.

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:simulation Virtual environment setups and simulations. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 18, 2024
Signed-off-by: xtk8532704 <[email protected]>
Signed-off-by: xtk8532704 <[email protected]>
@xtk8532704 xtk8532704 changed the title feat(tier4_control_launch): use preset.yaml to control which modules to launch for control modules feat(control): use preset.yaml to control which modules to launch for control modules Nov 18, 2024
@xtk8532704 xtk8532704 closed this Nov 18, 2024
@xtk8532704 xtk8532704 reopened this Nov 18, 2024
@xtk8532704 xtk8532704 marked this pull request as ready for review November 18, 2024 07:15
@xtk8532704
Copy link
Contributor Author

@takayuki5168 Would you please review this PR.

@xtk8532704
Copy link
Contributor Author

@mitsudome-r @yukkysaito Would you please check this PR. many thanks.

@xtk8532704 xtk8532704 merged commit c42bd46 into autowarefoundation:main Nov 19, 2024
27 checks passed
@xtk8532704 xtk8532704 deleted the xtk/cotrol-preset branch November 19, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants