Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): move dynamic_avoidance last #593

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 26, 2023

Description

The dynamic avoidance module should be launched at last since the algorithm will not fix the path requesting the approval as other modules do.

Tests performed

Nothing (dynamic avoidance is not used by default)

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 marked this pull request as ready for review September 26, 2023 02:52
@takayuki5168 takayuki5168 force-pushed the feat/move-dynamic-avoidance-last branch from 8d11106 to e201d26 Compare September 26, 2023 02:55
@takayuki5168 takayuki5168 force-pushed the feat/move-dynamic-avoidance-last branch from e201d26 to 189a003 Compare September 26, 2023 02:56
@takayuki5168 takayuki5168 merged commit 4dd0aca into autowarefoundation:main Sep 26, 2023
8 of 9 checks passed
@takayuki5168 takayuki5168 deleted the feat/move-dynamic-avoidance-last branch September 26, 2023 09:45
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
Signed-off-by: Takayuki Murooka <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
takayuki5168 referenced this pull request in tier4/autoware_launch Nov 26, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…undation#593)

* feat(diagnostic_graph_aggregator): add graph config files

Signed-off-by: Tomohito Ando <[email protected]>

* fix pre-commit error

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
* feat(diagnostic_graph_aggregator): add graph config files

Signed-off-by: Tomohito Ando <[email protected]>

* fix pre-commit error

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants