Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detected_object_validation): add param #669

Merged

Conversation

badai-nguyen
Copy link
Contributor

Description

This to add parameter for autowarefoundation/autoware.universe#5327 and should be merged together.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6aa816b) 0.00% compared to head (7126a40) 0.00%.
Report is 16 commits behind head on main.

❗ Current head 7126a40 differs from pull request most recent head bfb579d. Consider uploading reports for the commit bfb579d to get more accurate results

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #669   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen
Copy link
Contributor Author

I add parameter for obstacle_pointcloud_based_validator and keep using 2d_validator as current version. Could you also approve this PR @yukkysaito

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit c97cf8b into autowarefoundation:main Nov 15, 2023
8 of 9 checks passed
@badai-nguyen badai-nguyen deleted the fix/add_3d_validator branch November 15, 2023 14:53
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…ault_perception_mode

fix: fix psim and default perception mode
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
… abandon to stop (#669)

* abandon_to_stop

Signed-off-by: Yuki Takagi <[email protected]>

* sync to pseudo_occlusion

Signed-off-by: Yuki Takagi <[email protected]>

* adonban to stop for sudden unknown object

---------

Signed-off-by: Yuki Takagi <[email protected]>
Co-authored-by: Shohei Sakai <[email protected]>
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants