Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(detection_by_tracker): organize parameter structure #811

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 22, 2024

Description

Organize parameter structure based on autowarefoundation/autoware.universe#4989

Tests performed

Confirmed that the node launches without error, with the parameters loaded successfully.

Effects on system behavior

No effect expected

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda requested a review from badai-nguyen January 22, 2024 06:17
@kminoda
Copy link
Contributor Author

kminoda commented Jan 22, 2024

@badai-nguyen Hi, would you review this PR?

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 000527b into autowarefoundation:main Jan 22, 2024
12 of 13 checks passed
@kminoda kminoda deleted the chore/detection_by_tracker/organize_parameter_file branch January 22, 2024 06:36
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants