-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e_simulator.launch): add argument for running the CARLA interface #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-clem
requested changes
Mar 15, 2024
Fixed Description Co-authored-by: Maxime CLEMENT <[email protected]>
maxime-clem
reviewed
Mar 15, 2024
maxime-clem
changed the title
Added additional arguments on e2e for running Autoware with CARLA
feat(e2e_simulator.launch): add argument for running the CARLA interface
Mar 18, 2024
Signed-off-by: Maxime CLEMENT <[email protected]>
Updated version
7 tasks
fixed some issue with map loading
github-actions
bot
added
the
component:simulation
Virtual environment setups and simulations. (auto-assigned)
label
May 15, 2024
maxime-clem
approved these changes
May 15, 2024
maxime-clem
requested review from
yukkysaito,
mitsudome-r and
xmfcx
as code owners
May 15, 2024 05:05
yukkysaito
reviewed
May 15, 2024
yukkysaito
reviewed
May 15, 2024
yukkysaito
requested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I made some comments.
removed carla_map param
removed carla_map requirement.
removed multiple same args
fixed some categorization
Kim-mins
approved these changes
May 23, 2024
yukkysaito
approved these changes
May 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yuki-takagi-66
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Aug 9, 2024
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Ericpotato
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Nov 6, 2024
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added additional arguments on e2e_launch for running Autoware with CARLA.
Needed to use the
carla_autoware
package to integrate Autoware with the CARLA simulator. See autowarefoundation/autoware.universe#6859Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.