Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e_simulator.launch): add argument for running the CARLA interface #924

Merged
merged 25 commits into from
May 27, 2024

Conversation

mraditya01
Copy link
Contributor

@mraditya01 mraditya01 commented Mar 15, 2024

Description

Added additional arguments on e2e_launch for running Autoware with CARLA.
Needed to use the carla_autoware package to integrate Autoware with the CARLA simulator. See autowarefoundation/autoware.universe#6859

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Fixed Description

Co-authored-by: Maxime CLEMENT <[email protected]>
@maxime-clem maxime-clem changed the title Added additional arguments on e2e for running Autoware with CARLA feat(e2e_simulator.launch): add argument for running the CARLA interface Mar 18, 2024
@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label May 15, 2024
@maxime-clem maxime-clem marked this pull request as ready for review May 15, 2024 05:05
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I made some comments.

@yukkysaito yukkysaito self-requested a review May 26, 2024 12:53
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx xmfcx merged commit 9ecea1f into autowarefoundation:main May 27, 2024
10 of 11 checks passed
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Aug 9, 2024
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Ericpotato pushed a commit to tier4/autoware_launch that referenced this pull request Nov 6, 2024
Signed-off-by: YuxuanLiuTier4Desktop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants