-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(carla_autoware): add interface to easily use CARLA with Autoware #6859
feat(carla_autoware): add interface to easily use CARLA with Autoware #6859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still testing this PR but here are some comments.
Mostly I think the instructions in the README need to be improved.
@Kim-mins can I ask you to test this PR ? I think you are using CARLA a lot so I am very interested in your feedback. |
@maxime-clem Absolutely! I read the instruction of the bridge, and I got some questions. Q1. Spawning the ego vehicleI could build and run the latest Autoware with the modified autoware_launch and autoware universe, but I cannot know how to spawn the ego vehicle with the bridge. (seems it works differently what I've used). First I ran Carla 0.9.15, and it was loaded with Town10. I also ran the latest Autoware with Town01(not 10), but nothing happens. Q2. Building the bridgeI also tried to build the bridge with the following commands,
but the log is as below, which seems the build was unsuccessful:
Actually, I could not know where to run the command. I didn't know where the Thank you for all your hard work! I've been really looking forward to it. |
It is not relevant to the testing, but I have one more question regarding the frequency. |
And this could be minor, |
@Kim-mins Thank you very much for the Feedback! We have updated the README file to provide more detailed explanation regarding the code and parameter used. Q1. Spawning the Ego vehicleEgo vehicle should have been spawned automatically at random location by default as you run the bridge. You can change the location to any specific coordinates (x, y, z) and orientation (roll, pitch, yaw) by setting the Q2. Building the bridgeI apologize for the confusion. I neglected to update the instructions for building the bridge individually, which still referenced the old Q3. Frequency AnnotationBy default, our bridge operates in synchronous mode with a 0.05-second timestep. The performance is not negatively impacted because the annotated frequency only affects the publishing rate of ROS messages, not the sensor tick rate within CARLA itself. In fact, reducing the publishing frequency can improve simulation time performance, as fewer computationally intensive functions during CARLA -> Autoware data conversion, such as Additional Question
Thank you for testing the latest version! I'll update the supported versions once the 2024.05 version is released so we have more stable version. Small updates can occasionally disrupt the bridge. (Happens before when Autoware required the |
Thank you for the response and modifications @mraditya01! Actually, I'm not familiar to ros2. Could you please provide me more details? Here are the commands I executed:
and I got RViz with no pose initialization, and Carla with Town10. At this stage, I guess I should run
It seems I should install dependencies, but I have no idea. Could you please help me? Thank you! |
If yes to the above, then can you share your logfile ? I want to make sure there is no issue with the |
Thank you for the response @maxime-clem. Here are the answers to your questions:
For the log file, I checked that Autoware runs well, but I cannot run the bridge now. To run the bridge, in my understanding, I should run
Thank you! |
I did not noticed your mention on Discord. I think we can continue the discussion there. Thanks! |
Signed-off-by: mraditya01 <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: mraditya01 <[email protected]>
Signed-off-by: mraditya01 <[email protected]>
4891711
to
bf0a4b0
Compare
Signed-off-by: Maxime CLEMENT <[email protected]>
38c5b6e
to
d1dd300
Compare
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6859 +/- ##
==========================================
- Coverage 15.09% 0.00% -15.10%
==========================================
Files 1967 1 -1966
Lines 135941 6 -135935
Branches 42122 0 -42122
==========================================
- Hits 20520 0 -20520
+ Misses 92700 6 -92694
+ Partials 22721 0 -22721
☔ View full report in Codecov by Sentry. |
…autowarefoundation#6859) Signed-off-by: mraditya01 <[email protected]> Signed-off-by: Maxime CLEMENT <[email protected]> Co-authored-by: Minsu Kim <[email protected]>
…autowarefoundation#6859) Signed-off-by: mraditya01 <[email protected]> Signed-off-by: Maxime CLEMENT <[email protected]> Co-authored-by: Minsu Kim <[email protected]>
…autowarefoundation#6859) Signed-off-by: mraditya01 <[email protected]> Signed-off-by: Maxime CLEMENT <[email protected]> Co-authored-by: Minsu Kim <[email protected]>
Description
The interface between CARLA and Autoware aims to bridge both systems.
Required this launch PR: autowarefoundation/autoware_launch#924
Related links
Tests performed
Tested on Town01 map from Link.
Environment Setup:
CARLA 0.9.15
Autoware.universe Main Branch
ROS2 Humble
Python 3.10
Ubuntu 22.04
Testing:
Confirmed the functionality of limiting vehicle velocity to 30 km/h by providing input via Autoware.
Verified that the vehicle's velocity did not exceed the specified limit during the test.
Replicated the reported issue by recreating the same path on the same map used in the initial observation.
Monitored the vehicle's behavior and trajectory during the test.
Confirmed that no issues occurred, indicating that the reported problem was not reproducible or no longer exists after further testing and investigation.
Video Working Example:
Video
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.