Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v.1.4.1 #154

Merged
merged 122 commits into from
May 24, 2019
Merged

Release v.1.4.1 #154

merged 122 commits into from
May 24, 2019

Conversation

argenos
Copy link
Contributor

@argenos argenos commented May 23, 2019

There are a few reasons to make this PR:

I'm not sure why Travis is not catching some of these errors when we make the PRs, but I've opened #153 for that.

Changes

Architecture

  • All actions (except for the speech-related ones) are embedded in a fault-tolerant state machine
  • The mdr_behaviours metapackage has been (re)introduced so that scenario states can be easily reused. All existing scenarios have been modified to make use of the behaviours
  • Ontology and knowledge base integration
    • Interfaces to the ontology and knowledge base are hosted in mas_knowledge_base
    • All action clients and behaviours have been modified to interact with the knowledge base through the interface rather than directly. All actions and behaviours can also interact with the ontology through the ontology interface.
    • A basic implementation of a find_object action has been added to illustrate the interaction with the ontology and knowledge base
  • The DMP API has been adapted to the newest upstream version
  • The ROSPlan interface has been improved
    • The interface has been adapted to the upstream version of ROSPlan
    • A default PDDL planning domain has been
    • An interface for interacting with the planner (adding/removing goals and invoking the planner programmatically) has been added
  • An Event monitoring message has been added for the purpose of data annotation

HRI

RoboCup scenarios

  • Skeleton implementations for the following RoboCup scenarios have been added:
    • take out the garbage
    • serve drinks

Refactoring

Related PRs and Issues

This PR closes b-it-bots/mas_perception#37

henrikschnor and others added 30 commits November 16, 2018 20:33
    This commit removes the outdated question matching approach from 2016. Methods to compare input have been improved since then and can be found in mdr_speech_matching. Further also the content of the README.md file has been removed. Once the new speech recognition and speech processing is set, this needs to be updated.
Remove outdated question matching approach.
Mbot interface implementation
…t Python package and modified most of the implementations there
@argenos argenos added Type: Enhancement New feature or request Type: Maintenance Changes due to version updates or CI setup labels May 23, 2019
@argenos argenos dismissed minhnh’s stale review May 23, 2019 17:22

Changes are being addressed in #145 or require their own issue

@alex-mitrevski
Copy link
Member

FYI, I've updated the PR description so that it describes the changes more accurately and extensively.

@argenos
Copy link
Contributor Author

argenos commented May 24, 2019

Sounds good! LGTM!

mas-domestic.rosinstall Show resolved Hide resolved
@argenos argenos requested a review from minhnh May 24, 2019 15:49
@argenos argenos merged commit b2a75ee into kinetic May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request Type: Maintenance Changes due to version updates or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with mas_domestic's kinetic branch
7 participants