Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning domain adaptations for issue #228 #229

Merged
merged 9 commits into from
Mar 25, 2023

Conversation

alex-mitrevski
Copy link
Member

Addresses #228

The following changes are made to the default domain with this PR:

  • The domain has been adapted for the LAMA planner
  • Various predicates and types from the ontology have been added to the domain
  • A hand-over action has been added
  • I additionally defined contexts for the pick and place actions and added two more versions of the actions for picking from/placing in a container

* Adapted the domain for the LAMA planner
* Added some predicates and types from the ontology
* Added two more pick and place versions and defined action contexts
* Added a hand-over action
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alex-mitrevski alex-mitrevski marked this pull request as draft September 5, 2020 09:42
The type of the status field has changed in the upstream ROSPlan
(instead of a string, it's now a status integer field as defined in the
message)
The initialisation has been updated according to the changes in the
ontology interface (introduced with commit 9889e057c03b1c159e9ce12967f69e0da2388f0d
in https://github.com/b-it-bots/mas_knowledge_base/tree/devel)
This is currently the only ontology we have with some assertions, so
it's best for running tests
@alex-mitrevski alex-mitrevski changed the title WIP: Planning domain adaptations for issue #228 Planning domain adaptations for issue #228 Mar 24, 2023
@alex-mitrevski alex-mitrevski marked this pull request as ready for review March 24, 2023 15:09
@alex-mitrevski alex-mitrevski requested a review from minhnh as a code owner March 24, 2023 15:09
@alex-mitrevski alex-mitrevski merged commit 1dc4dd4 into devel Mar 25, 2023
@alex-mitrevski alex-mitrevski deleted the feature/planning-with-info-from-ontology branch March 25, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants