Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: moving integration e2e to babylon-sdk #68

Merged
merged 16 commits into from
Dec 14, 2024
Merged

Conversation

SebastianElvis
Copy link
Member

@SebastianElvis SebastianElvis commented Dec 11, 2024

Resolves #64

  • move ibcsim-bcd to babylon-sdk
  • move bcd_consumer_integration to babylon-sdk
  • add relevant Make commands
  • add integration e2e to CI

@SebastianElvis SebastianElvis marked this pull request as ready for review December 12, 2024 05:56
SebastianElvis added a commit to babylonlabs-io/babylon that referenced this pull request Dec 13, 2024
Part of babylonlabs-io/babylon-sdk#64

This PR removes all e2e tests related to BTC staking integration. These
tests will then be put in babylon-sdk repository
([PR](babylonlabs-io/babylon-sdk#68))
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work.

Comment on lines 13 to 26

- name: Build IBC Simulator BCD Image
run: make build-ibcsim-bcd

- name: Build Babylond Image
run: make build-babylond

- name: Cache Go
uses: actions/setup-go@v5
with:
go-version: 1.23

- name: Run Integration Tests
run: sudo make test-e2e-bcd-consumer-integration
Copy link
Contributor

@maurolacy maurolacy Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to create a comprehensive test-e2e target in the Makefile, and call it from here. I'm pushing a companion / follow-up PR with some small improvements, if you don't mind.

Update: #70.

@maurolacy maurolacy mentioned this pull request Dec 13, 2024
Small follow-up
@maurolacy maurolacy merged commit eabe629 into main Dec 14, 2024
13 checks passed
@maurolacy maurolacy deleted the integration-e2e-test branch December 14, 2024 10:20
@maurolacy maurolacy mentioned this pull request Dec 14, 2024
maurolacy added a commit that referenced this pull request Dec 16, 2024
Another follow-up to #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: move integration e2e tests from Babylon to Babylon SDK
2 participants