Modernize build pipeline #4132
Merged
Modernize build pipeline #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfunckt
commented
Nov 1, 2023
dfunckt
commented
Nov 1, 2023
| # https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks | ||
| # https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks#about-workflow-runs-from-public-forks | ||
| CSC_FOR_PULL_REQUEST: true | ||
|
|
||
| # https://www.electron.build/auto-update.html#staged-rollouts | ||
| - name: Configure staged rollout(s) |
There was a problem hiding this comment.
I don't think this actually worked for a while now (or the auto-update mechanism in general). I'll remove everything for now and re-introduce auto-updates properly later on -- Electron Forge has a simple way to do that (but no way for staged rollouts AFAIK)
dfunckt
commented
Nov 1, 2023
| "webpack-dev-server": "4.11.1" | ||
| "url-loader": "4.1.1" | ||
| }, | ||
| "hostDependencies": { |
There was a problem hiding this comment.
Not sure how good this choice will turn out to be, but I wanted to avoid what we declare as app dependencies for deb to get out of sync with what we install on CI, so this will have to do for now.
dfunckt
force-pushed
the
switch-to-electron-forge
branch
13 times, most recently
from
2e659e0 to
cb117d8
Compare
dfunckt
force-pushed
the
switch-to-electron-forge
branch
14 times, most recently
from
6dac465 to
776b72d
Compare
dfunckt
force-pushed
the
switch-to-electron-forge
branch
3 times, most recently
from
bec1c16 to
e90c3fc
Compare
Change-type: minor
dfunckt
force-pushed
the
switch-to-electron-forge
branch
from
e90c3fc to
b34bd54
Compare
dfunckt
force-pushed
the
switch-to-electron-forge
branch
3 times, most recently
from
27cb993 to
169f3c1
Compare
Change-type: minor
Change-type: minor
dfunckt
force-pushed
the
switch-to-electron-forge
branch
from
36d4c01 to
a0dd6c5
Compare
|
Thank you for shasums! Gotta love this: |
This was referenced Dec 22, 2023
|
@dfunckt @aethernet I've not tested this yet, but congratulations on getting this big update over the line 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to electron-forge which is now officially adopted by the Electron project. Solves a bunch of issues along the way.
Issues related to experimental v1.18.13:
Closes #4138
Closes #4129
Closes #4119
Build related issues:
Closes #4136
Closes #4125
Closes #4103
Closes #4087
Closes #3767
Closes #3728
Closes #3653
Closes #3400
Closes #3292
Closes #3269
Closes #3263
Closes #2870
Closes #2826
(Admittedly, some of the issues are linked opportunistically -- please reopen them if the issue is not actually solved)