Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New spanish translations #7319

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dgruano
Copy link
Contributor

@dgruano dgruano commented Dec 31, 2024

As promised, some more updates for the Spanish localization:

  • Add new translations to reach 100% coverage

  • Change example name from Alice to Alicia in all examples

  • Make new strings translatable

    • "Posts" and "Publications" (lists page) and "Following" tab
    • Run lingui extract
    • Add translation to Spanish for those strings
  • Some fixes:

    • Roll back to "Me gusta" for the "Likes" tab in profile (my bad)
    • Change "desmutear" and derivatives to "Dejar de silenciar"
    • Other minor fixes
  • To validate:

    • src/screens/Profile/components/ProfileFeedHeader.tsx:353
      menú de feeds (menu "of feeds") or menú del feed (menu "of the feed")?

    • src/view/screens/ProfileList.tsx:683 (and others)
      Dejar de fijar?"

  • TODO: Delete obsolete strings from locales. Is there any criteria to do this, or can they be deleted right away?

- Add new translations to reach 100% coverage
- Change example name from Alice to Alicia in all examples
- Change "desmutear" and derivatives to "Dejar de silenciar"
- Remove comments
- Minor fixes
- "Posts" and "Publications" (lists page) and "Following" tab
- Run lingui extract
- Translate those strings to Spanish
- Translate other remaining strings to Spanish

To validate:
src/screens/Profile/components/ProfileFeedHeader.tsx:353
menú de feeds (menu "of feeds") or menú del feed (menu "of the feed")?

src/view/screens/ProfileList.tsx:683 (and others)
Dejar de fijar?"

TODO: Delete obsolete strings from locales
@@ -162,6 +159,7 @@ function ProfileListScreenLoaded({
const isHidden = list.labels?.findIndex(l => l.val === '!hide') !== -1
const isOwner = currentAccount?.did === list.creator.did
const scrollElRef = useAnimatedRef()
const SECTION_TITLES_CURATE = [_(msg`Posts`), _(msg`People`)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7175 is already working on this, I suggest keeping it separate from the Spanish translation update PR to avoid overlaps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks! I didn't notice. Will roll back the changes then.

@auroursa
Copy link
Contributor

auroursa commented Jan 1, 2025

Let’s first resolve some merge conflicts. When updating messages.po, please specify the language, for example:
yarn intl:extract --locale es

This ensures we keep changes scoped to Spanish translations only.

- Solved conflicts in Spanish locale
- "Theirs" strategy for the rest of locales
- Rollback ProfileList.tsx to avoid overlap with bluesky-social#7175
@dgruano
Copy link
Contributor Author

dgruano commented Jan 1, 2025

I think that should solve the merge conflicts. What I did:

  • Merge "main" onto my locale branch, keeping all files from "main" and resolving conflicts between branches for the Spanish locale. This includes rolling back my changes to ProfileList.tsx to localize the tab titles.
  • Fix a typo duplicated string "Start adding people!" with and without exclamation in ProfileList.tsx
  • Extract and translate only es locale, as suggested.

Thank you for your help and guidance! Happy to make any other changes if needed.

@auroursa
Copy link
Contributor

auroursa commented Jan 2, 2025

Thank you for your efforts, but could we revert the changes to messages.po files for all languages except Spanish? Updating all languages makes the PR harder to review.

I noticed your improvements to src/state/queries/feed.ts and src/view/screens/ProfileList.tsx—great work! But I believe these changes should be reviewed in a separate PR to keep this one focused solely on updating the Spanish language files. This approach would help to expedite the merging process.

@auroursa
Copy link
Contributor

auroursa commented Jan 2, 2025

@GersonLazaro @ovniroto Would anyone be willing to review the improvements proposed in this PR? It would be great if someone could take a look!

src/locale/locales/es/messages.po Outdated Show resolved Hide resolved
src/locale/locales/es/messages.po Outdated Show resolved Hide resolved
src/locale/locales/es/messages.po Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants