Update browser matrix to use iOS 11 #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
changed the title
| @@ -178,6 +178,7 @@ steps: | |||
| - ios_10 | |||
| depends_on: "browser-maze-runner-bs" | |||
| timeout_in_minutes: 30 | |||
| soft_fail: true | |||
There was a problem hiding this comment.
As discussed IRL this would unfortunately mean allow fails on safari 16 too. Suggest bumping to ios_11 or remove use of the matrix and just have separate steps, with one set to soft_fail.
twometresteve
approved these changes
Nov 29, 2024
| @@ -1,7 +1,7 @@ | |||
| @plugin_angular | |||
|
|
|||
| # Skipped on older Safari versions not supported by Angular 10 - Angular renders the fixture component twice, causing duplicate events to be reported | |||
| @skip_safari_10 @skip_ios_10 | |||
| @skip_safari_10 @skip_below_ios_13 | |||
There was a problem hiding this comment.
For this to work you have to implement the tag @skip_below_ios_13 yourself, there's no magic behind it. See skip.rb for the definitions of them.
There was a problem hiding this comment.
there is an implementation present in packages/react-native/ios/vendor/bugsnag-cocoa/features/support/env.rb which I thought would be used?
gingerbenw
force-pushed
the
gingerbenw/soft-fail-ios-10
branch
from
8dd3b94 to
eff2496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Resolve pipeline instability by updating iOS 10 to iOS 11 tests as BrowserStack device availability has been causing consistent test failures
Add new skip steps for iOS devices