feat: Removed attach command

[jirihnidek]

• Card ID: CCT-425

Attach command

• Removed attach command
• Removed --auto-attach and --autosubscribe CLI options of
  register command
• Removed --servicelevel CLI option of register command too,
  because this CLI option was possible to use only with
  --auto-attach CLI option. Thus, it does not make sense
  to keep this option
• Removed unit tests for attach command
• Modified unit tests for register command. Only SCA mode
  is considered.
• Modified man pages

D-Bus

• Removed interface: com.redhat.RHSM1.Attach
• Removed AutoAttach and PoolAttach
• Modified Register method
• Removed unit tests related to removed methods
• Modified unit tests of register D-Bus methods

Attach service

• Removed attach service
• Removed unit tests related to attach service

[github-actions]

Coverage (computed on Fedora latest) •

File	Stmts	Miss	Cover	Missing
__init__.py	0	0	100%
rhsmlib/dbus/objects
__init__.py	8	0	100%
register.py	201	62	69%	35, 88–89, 102–103, 113–114, 116–117, 127–128, 130, 144, 147, 160, 163, 202, 211, 249–250, 257, 275, 283, 286, 329–331, 333–334, 353–356, 358–360, 362, 364, 366, 381, 385, 402–407, 409–411, 413, 415, 427–431, 433–435, 437, 439
subscription_manager
managercli.py	48	12	75%	22, 80–82, 84, 86–91, 95
subscription_manager/cli_command
cli.py	206	28	86%	64, 68, 124, 181, 185, 187, 230, 269, 280–282, 296–298, 321, 341, 367, 376–377, 381–382, 398, 400–401, 403–404, 409, 417
register.py	204	45	77%	120, 122, 165–167, 169–170, 173, 184, 188, 195–198, 202–203, 207–208, 219, 247, 251–253, 262, 266, 292, 308–309, 345, 374, 382, 397–399, 408, 439, 449–450, 457–458, 463–467
subscription_manager/scripts
rhsm_service.py	15	15	0%	17, 19–20, 23, 26–28, 31–33, 43–45, 48–49
TOTAL	18014	4538	74%

Tests	Skipped	Failures	Errors	Time
2534	14 💤	0 ❌	0 🔥	34.229s ⏱️

[m-horky]

There are still many references to attaching in the code, but that would be out of scope for the command. However, I found

subscription-manager/src/subscription_manager/cli_command/cli.py

Lines 118 to 135 in b667da0

	def _print_ignore_auto_attach_message(self):
	"""
	This message is shared by attach command and register command, because
	both commands can do auto-attach.
	:return: None
	"""
	owner = get_current_owner(self.cp, self.identity)
	# We displayed Owner name: `owner_name = owner['displayName']`, but such behavior
	# was not consistent with rest of subscription-manager
	# Look at this comment: https://bugzilla.redhat.com/show_bug.cgi?id=1826300#c8
	owner_id = owner["key"]
	print(
	_(
	"Ignoring the request to auto-attach. "
	'Attaching subscriptions is disabled for organization "{owner_id}" '
	"because Simple Content Access (SCA) is enabled."
	).format(owner_id=owner_id)
	)

that I believe should be part of this patch.

Otherwise LGTM. I won't block this PR on this change, we'll find it later during cleanup work.

[ptoscano]

This must not be merged before candlepin/subscription-manager-cockpit#68 is merged, otherwise the cockpit tests will fail (like they currently do).

[ptoscano]

This is OK, so I can merge this.

There are few more things related to these changes to fix:

• etc-conf/dbus/system.d/com.redhat.RHSM1.conf: traces of the removed D-Bus interface
• src/rhsmlib/dbus/constants.py: the now unused ATTACH_INTERFACE and ATTACH_DBUS_PATH constants

One or more followup PRs would be nice, thanks!