Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Watchtowers #7754

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Adds Watchtowers #7754

wants to merge 39 commits into from

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Dec 6, 2024

About the pull request

Adds watchtowers

Construction:
zqxqUHb (1)

  1. Make 2x2 of dislodged girders
  2. Welder the bottom left dislodged girder
  3. 60 metal rods
  4. Blowtorch, Wrench
  5. Screwdriver + 50 metal in offhand
  6. Crowbar + 25 plasteel in offhand
  7. Wrench + 60 metal rods in offhand
  8. Blowtorch + 25 plasteel in offhand

Hitboxes:
Orange - Removed in later commit, ignore
Red - Always blocks movement (two 2x1s)
Green - Allows movement if you are ontop of the watchtower (1x2, this is where you after climbing into the watchtower)
image

Mechanics:

  1. Only marines and non-big xenomorphs can climb the watchtower, from the tile infront of the ladder
  2. Being ontop of the tower gives you 2 extra tiles of view and makes your shots arc so they only hit what you click, skipping all other mobs
  3. Xenos can damage the tower by slashing it
  4. Marines can repair the tower by patching it with a welder and metal in offhand
  5. The tower does not protect you from most xeno abilities

Explain why it's good for the game

Besides the fact it's cool I cannot tell if it is actually good for the game without some testing and adjusting

Testing Photographs and Procedure

Some videos are from different commits so they might be outdated but they show the general concept

2024-12-06.19-40-11.mp4
2024-12-06.18-12-14.mp4

Uploading 2024-12-05 21-38-03.mp4…

Changelog

🆑 Nivrak, Thwomper
add: Added watchtowers, sprites by thwomper
/:cl:

@cmss13-ci cmss13-ci bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Dec 6, 2024
code/datums/elements/bullet_trait/direct_only.dm Outdated Show resolved Hide resolved
code/datums/elements/bullet_trait/direct_only.dm Outdated Show resolved Hide resolved
code/datums/elements/bullet_trait/direct_only.dm Outdated Show resolved Hide resolved
code/modules/watchtower/watchtower.dm Outdated Show resolved Hide resolved
code/modules/watchtower/watchtower.dm Outdated Show resolved Hide resolved
code/modules/watchtower/watchtower.dm Outdated Show resolved Hide resolved
code/game/objects/structures/girders.dm Outdated Show resolved Hide resolved
@kiVts kiVts marked this pull request as draft December 9, 2024 20:01
@Git-Nivrak Git-Nivrak marked this pull request as ready for review December 9, 2024 22:09
cm13-github added a commit that referenced this pull request Dec 10, 2024
cm13-github added a commit that referenced this pull request Dec 24, 2024
cm13-github added a commit that referenced this pull request Dec 24, 2024
cm13-github added a commit that referenced this pull request Dec 24, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 25, 2024
cm13-github added a commit that referenced this pull request Dec 27, 2024
@Git-Nivrak Git-Nivrak marked this pull request as ready for review December 28, 2024 10:01
Copy link
Contributor

@Blundir Blundir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spriter should redo the ladder sprite, elaborated on discord

@Blundir Blundir marked this pull request as draft January 10, 2025 20:08
@cmss13-ci
Copy link
Contributor

cmss13-ci bot commented Jan 23, 2025

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci bot added the Stale beg a maintainer to review your PR label Jan 23, 2025
@Git-Nivrak Git-Nivrak marked this pull request as ready for review January 24, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Remove the soul from the game. Stale beg a maintainer to review your PR Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

9 participants