Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19645] ThreadSettings documentation #590

Merged
merged 15 commits into from
Nov 21, 2023
Merged

[19645] ThreadSettings documentation #590

merged 15 commits into from
Nov 21, 2023

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Nov 6, 2023

This PR adds documentation for the feature provided in Fast DDS ThreadSettings.
Depends on:

@EduPonz EduPonz added the implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS label Nov 6, 2023
@EduPonz EduPonz added this to the v2.13.0 milestone Nov 6, 2023
MiguelCompany
MiguelCompany requested changes Nov 8, 2023
View reviewed changes
docs/fastdds/library_overview/includes/exec_model.rst Outdated Show resolved Hide resolved
docs/fastdds/library_overview/includes/exec_model.rst Show resolved Hide resolved
docs/fastdds/logging/logging_thread.rst Outdated Show resolved Hide resolved
docs/fastdds/transport/shared_memory/shared_memory.rst Outdated Show resolved Hide resolved
docs/fastdds/transport/shared_memory/shared_memory.rst Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
docs/fastdds/xml_configuration/common.rst Show resolved Hide resolved
docs/fastdds/xml_configuration/domainparticipantfactory.rst Show resolved Hide resolved
MiguelCompany
MiguelCompany previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

MiguelCompany
MiguelCompany previously approved these changes Nov 10, 2023
View reviewed changes
@EduPonz EduPonz force-pushed the feature/thread-config/main branch 2 times, most recently from feb8eae to 6a03feb Compare November 10, 2023 11:41
@MiguelCompany MiguelCompany removed the implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS label Nov 13, 2023
MiguelCompany
MiguelCompany approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany reopened this Nov 13, 2023
@EduPonz EduPonz mentioned this pull request Nov 13, 2023
Merged
11 tasks
MiguelCompany and others added 15 commits November 20, 2023 16:37
@MiguelCompany @EduPonz
Refs #19645. Fix cardinality and add TCP accept thread.
9520bc4 
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@MiguelCompany @EduPonz
Refs #19645. Add OS thread name column.
44356e8 
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@MiguelCompany @EduPonz
Refs #19645. Add basic section for ThreadSettings.
b3453de 
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: Reference ThreadSettings section in execution model
6d0b2b7 
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: DomainParticipantFactory ThreadSettings configuration
f11e0c2 
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: DomainParticipant ThreadSettings configuration
c6b672c 
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: PortBasedTransportDescriptor ThreadSettings configuration
29c7481 
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: SHM ThreadSettings configuration
30346f4 
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: FlowControllerDescriptor ThreadSettings configuration
48771ff 
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: DataReader ThreadSettings configuration
39e3f93 
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: Log ThreadSettings configuration
b787188 
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: Apply Miguel's suggestions
cf8f00c 
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: Apply Miguel's suggestions 2
5482b0f 
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: Add missing TCPTransportDescriptor thread settings
31b76c4 
Signed-off-by: EduPonz <[email protected]>
@EduPonz
Refs #19645: Add missing includes
1ed257f 
Signed-off-by: EduPonz <[email protected]>
@EduPonz EduPonz force-pushed the feature/thread-config/main branch from 6a03feb to 1ed257f Compare November 20, 2023 15:37
@EduPonz EduPonz merged commit 60557c4 into master Nov 21, 2023
4 checks passed
@EduPonz EduPonz deleted the feature/thread-config/main branch November 21, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @MiguelCompany