Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21329] Update DataWriter::write return value as ReturnCode_t #158

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 10, 2024

Description

This PR is the corresponding applied to this repo the Fast DDS PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • ❌ Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v2.0.0 milestone Jul 10, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 10, 2024
@JesusPoderoso JesusPoderoso requested a review from elianalf July 10, 2024 11:18
@JesusPoderoso JesusPoderoso changed the title [21329] Update DataWriter::write return value as ReturnCode_t [21329] Update DataWriter::write return value as ReturnCode_t Jul 10, 2024
@EduPonz EduPonz requested a review from elianalf July 11, 2024 07:44
@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 11, 2024
@EduPonz EduPonz merged commit 9214250 into main Jul 11, 2024
4 checks passed
@EduPonz EduPonz deleted the hotfix/21329 branch July 11, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants