Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21329] All DataWriter::write overload shall return RerturnCode_t type #5049

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 10, 2024

Description

There were different DataWriter::write methods that return either bool or a ReturnCode_t.
This PR makes them all return a ReturnCode_t type, and updates their usage among the repo code.

Related impl PRs:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jul 10, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 10, 2024
@JesusPoderoso JesusPoderoso requested a review from elianalf July 10, 2024 10:07
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 10, 2024
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf July 10, 2024 10:08
include/fastdds/dds/publisher/DataWriter.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/publisher/DataWriter.hpp Outdated Show resolved Hide resolved
@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 11, 2024
@JesusPoderoso JesusPoderoso removed the ci-pending PR which CI is running label Jul 11, 2024
@EduPonz EduPonz merged commit a138ed5 into master Jul 11, 2024
16 of 17 checks passed
@EduPonz EduPonz deleted the hotfix/21329 branch July 11, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants