Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20542] Fix CI version management #4481

Merged
merged 13 commits into from
Mar 14, 2024
Merged

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Feb 29, 2024

Description

This PR unifies the CI in all workflows to follow this behavior:

  • Trigger CI in all pull requests which HEAD branch is set to this supported branch version
  • Remove any CI trigger on push events and nightly
  • Include missing ignore files for the sanitizer event trigger.
  • Rename sanitizer job as "address-sanitizer"

It also includes missing changes to fully support 2.13.x

master related PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

.github/workflows/config/default_ci_2.13.x.repos Outdated Show resolved Hide resolved
.github/workflows/documentation-tests.yaml Outdated Show resolved Hide resolved
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci_version_management_2.13.x branch from 8ff35dd to 0146032 Compare March 5, 2024 14:41
elianalf
elianalf previously approved these changes Mar 6, 2024
elianalf
elianalf previously approved these changes Mar 6, 2024
elianalf
elianalf previously approved these changes Mar 6, 2024
@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 6, 2024
@EduPonz EduPonz force-pushed the hotfix/ci_version_management_2.13.x branch from db483a4 to f70592a Compare March 9, 2024 08:29
@EduPonz EduPonz added no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI labels Mar 13, 2024
JesusPoderoso and others added 10 commits March 13, 2024 16:56
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@EduPonz EduPonz force-pushed the hotfix/ci_version_management_2.13.x branch from f70592a to 5386558 Compare March 13, 2024 15:56
@EduPonz EduPonz merged commit 0898631 into 2.13.x Mar 14, 2024
10 checks passed
@EduPonz EduPonz deleted the hotfix/ci_version_management_2.13.x branch March 14, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants