Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20542] Fix CI version management #4482

Merged
merged 11 commits into from
Mar 14, 2024
Merged

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Feb 29, 2024

Description

This PR unifies the CI in all workflows to follow this behavior:

  • Trigger CI in all pull requests which HEAD branch is set to this supported branch version
  • Remove any CI trigger on push events and nightly
  • Include missing ignore files for the sanitizer event trigger.
  • Rename sanitizer job as "address-sanitizer"

master related PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Feb 29, 2024
@JesusPoderoso JesusPoderoso added this to the v2.12.2 milestone Feb 29, 2024
@JesusPoderoso JesusPoderoso self-assigned this Feb 29, 2024
.github/workflows/sanitizer-tests.yaml Outdated Show resolved Hide resolved
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci_version_management_2.12.x branch from f608899 to 25204ae Compare March 5, 2024 14:42
elianalf
elianalf previously approved these changes Mar 6, 2024
elianalf
elianalf previously approved these changes Mar 8, 2024
@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 8, 2024
@EduPonz EduPonz force-pushed the hotfix/ci_version_management_2.12.x branch from 926a951 to 9c33fd5 Compare March 9, 2024 08:28
@elianalf elianalf added ci-pending PR which CI is running and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. skip-ci Automatically pass CI labels Mar 11, 2024
@elianalf elianalf closed this Mar 11, 2024
@elianalf elianalf reopened this Mar 11, 2024
elianalf
elianalf previously approved these changes Mar 11, 2024
@elianalf elianalf added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Mar 11, 2024
@EduPonz EduPonz force-pushed the hotfix/ci_version_management_2.12.x branch from 9c33fd5 to 62f7af2 Compare March 13, 2024 15:00
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
JesusPoderoso and others added 6 commits March 13, 2024 16:09
@EduPonz EduPonz force-pushed the hotfix/ci_version_management_2.12.x branch from af0c10a to f544dd1 Compare March 13, 2024 15:09
@EduPonz EduPonz added the no-test Skip CI tests if PR marked with this label label Mar 13, 2024
@EduPonz EduPonz closed this Mar 13, 2024
@EduPonz EduPonz reopened this Mar 13, 2024
@JesusPoderoso
Copy link
Contributor Author

Documentation Manual CI run here
Consider Ready to merge if passes, it is depending on this documentation PR:

@EduPonz EduPonz merged commit fa2c790 into 2.12.x Mar 14, 2024
13 of 21 checks passed
@EduPonz EduPonz deleted the hotfix/ci_version_management_2.12.x branch March 14, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants