Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20542] Fix CI version management #4484

Merged
merged 12 commits into from
Mar 14, 2024
Merged

[20542] Fix CI version management #4484

merged 12 commits into from
Mar 14, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Feb 29, 2024 •
edited
Loading

Description

This PR unifies the CI in all workflows to follow this behavior:

  • Trigger CI in all pull requests which HEAD branch is set to this supported branch version
  • Remove any CI trigger on push events and nightly
  • Include missing ignore files for the sanitizer event trigger.
  • Rename sanitizer job as "address-sanitizer"

master related PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Feb 29, 2024
@JesusPoderoso JesusPoderoso added this to the v2.6.8 milestone Feb 29, 2024
@JesusPoderoso JesusPoderoso self-assigned this Feb 29, 2024
@JesusPoderoso JesusPoderoso mentioned this pull request Feb 29, 2024
Merged
6 tasks
elianalf
elianalf previously approved these changes Mar 5, 2024
View reviewed changes
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

@Mario-DL Mario-DL added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 5, 2024
@JesusPoderoso JesusPoderoso added to-do and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Mar 5, 2024
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci_version_management_2.6.x branch from acfde26 to 2ee92e0 Compare March 5, 2024 14:43
Mario-DL
Mario-DL previously approved these changes Mar 6, 2024
View reviewed changes
@Mario-DL Mario-DL added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 6, 2024
@Mario-DL Mario-DL removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 6, 2024
elianalf
elianalf previously approved these changes Mar 6, 2024
View reviewed changes
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci_version_management_2.6.x branch from 9575222 to 0990394 Compare March 6, 2024 15:14
Mario-DL
Mario-DL previously approved these changes Mar 8, 2024
View reviewed changes
@Mario-DL Mario-DL added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 8, 2024
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci_version_management_2.6.x branch from 0990394 to 0dc5418 Compare March 8, 2024 08:09
@EduPonz EduPonz force-pushed the hotfix/ci_version_management_2.6.x branch from 0dc5418 to b008de7 Compare March 9, 2024 08:27
@EduPonz EduPonz mentioned this pull request Mar 9, 2024
Merged
7 tasks
@Mario-DL Mario-DL removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 13, 2024
@JesusPoderoso @EduPonz
Refs #20542: Fix CI version management
0cb0169 
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@JesusPoderoso @EduPonz
Refs #20542: Apply internal revision suggestions
9a85b3a 
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@JesusPoderoso @EduPonz
Refs #20542: Add ignored paths to sanitizer events
2260c87 
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@JesusPoderoso @EduPonz
Refs #20542: Remove nightly files
b1f397d 
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@EduPonz EduPonz force-pushed the hotfix/ci_version_management_2.6.x branch from b008de7 to 8a47ccb Compare March 13, 2024 11:27
Mario-DL
Mario-DL reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be that we are missing ci.meta under .github/workflows/config?

Mario-DL
Mario-DL previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice job on this PR

@EduPonz EduPonz added no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI labels Mar 13, 2024
@EduPonz EduPonz mentioned this pull request Mar 14, 2024
Merged
7 tasks
@EduPonz EduPonz merged commit 75d6958 into 2.6.x Mar 14, 2024
10 checks passed
@EduPonz EduPonz deleted the hotfix/ci_version_management_2.6.x branch March 14, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

@elianalf elianalf elianalf left review comments

Assignees

@JesusPoderoso JesusPoderoso

Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.6.8
Development

Successfully merging this pull request may close these issues.
4 participants
@JesusPoderoso @elianalf @Mario-DL @EduPonz