[20584] Effectively assert automatic/manual_by_participant liveliness #4501

Mario-DL · 2024-03-05T07:14:48Z

Description

This PR brings a bugfix when asserting AUTOMATIC MANUAL_BY_PARTICIPANT liveliness kinds. In the scenario of having a participant with two datareaders (each of them with a lease duration of 2 secs) and other two participants with one publisher each one configured with AUTOMATIC_LIVELINESS. If we suddenly kill one of the publishers (network disconnection or Ctrl+C), the on_liveliness_changed() is not received on the reader side when we would expect it to happen (after 2 secs).

The problem stems from the fact that currently, in the reader-side participant, it is enough having an alive writer with the same kind (AUTOMATIC_LIVELINESS) to assert the liveliness of all of its readers with the same kind regardless of the participant.

This PR makes the liveliness assertion participant-aware by means of the guidPrefix.

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Fixes #4373

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Mario-DL · 2024-03-05T07:27:22Z

@richiprosima please test linux test discovery_server

MiguelCompany · 2024-03-11T15:44:32Z

@Mergifyio rebase

mergify · 2024-03-11T15:47:07Z

rebase

✅ Branch has been successfully rebased

test/blackbox/api/dds-pim/PubSubParticipant.hpp

test/blackbox/api/fastrtps_deprecated/PubSubParticipant.hpp

test/blackbox/common/BlackboxTestsLivelinessQos.cpp

include/fastdds/rtps/writer/LivelinessManager.h

JesusPoderoso · 2024-03-13T22:58:29Z

@richiprosima please test this

Mario-DL · 2024-03-14T10:58:39Z

@richiprosima please test this

EduPonz · 2024-03-20T18:53:15Z

@Mergifyio rebase master

Signed-off-by: Mario Dominguez <[email protected]>

… writer announcement period and lease duration test's writers Signed-off-by: Mario Dominguez <[email protected]>

mergify · 2024-03-20T18:53:56Z

rebase master

✅ Branch has been successfully rebased

EduPonz · 2024-03-20T18:55:24Z

@richiprosima please test this

EduPonz · 2024-03-21T06:47:49Z

@Mergifyio backport 2.13.x 2.10.x 2.6.x

mergify · 2024-03-21T06:47:54Z

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

#4594 [20584] Effectively assert automatic/manual_by_participant liveliness (backport #4501) has been created for branch 2.13.x
#4595 [20584] Effectively assert automatic/manual_by_participant liveliness (backport #4501) has been created for branch 2.10.x
#4596 [20584] Effectively assert automatic/manual_by_participant liveliness (backport #4501) has been created for branch 2.6.x

* Refs #20584: Add BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Update LivelinessManager tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Apply reviewer suggestions Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Fix PubSubParticipant comparison and add padding between writer announcement period and lease duration test's writers Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit f708244)

…#4596) * Refs #20584: Add BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Update LivelinessManager tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Apply reviewer suggestions Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Fix PubSubParticipant comparison and add padding between writer announcement period and lease duration test's writers Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit f708244) Co-authored-by: Mario Domínguez López <[email protected]>

…#4594) * Refs #20584: Add BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Update LivelinessManager tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Apply reviewer suggestions Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Fix PubSubParticipant comparison and add padding between writer announcement period and lease duration test's writers Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit f708244) Co-authored-by: Mario Domínguez López <[email protected]>

* Refs #20584: Add BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Update LivelinessManager tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Apply reviewer suggestions Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Fix PubSubParticipant comparison and add padding between writer announcement period and lease duration test's writers Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit f708244)

…#4595) * Refs #20584: Add BB test Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Fix Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Update LivelinessManager tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Apply reviewer suggestions Signed-off-by: Mario Dominguez <[email protected]> * Refs #20584: Fix PubSubParticipant comparison and add padding between writer announcement period and lease duration test's writers Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit f708244) Co-authored-by: Mario Domínguez López <[email protected]>

Mario-DL added this to the v2.14.1 milestone Mar 5, 2024

Mario-DL added needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Mar 5, 2024

MiguelCompany force-pushed the bugfix/20584 branch from a3469d5 to 703d3d6 Compare March 11, 2024 15:47

MiguelCompany self-requested a review March 13, 2024 08:10

MiguelCompany requested changes Mar 13, 2024

View reviewed changes

MiguelCompany removed the needs-review PR that is ready to be reviewed label Mar 13, 2024

MiguelCompany previously approved these changes Mar 13, 2024

View reviewed changes

Mario-DL dismissed MiguelCompany’s stale review via 89f0b06 March 14, 2024 07:15

MiguelCompany approved these changes Mar 14, 2024

View reviewed changes

Mario-DL added 6 commits March 20, 2024 18:53

Refs #20584: Add BB test

50d864b

Signed-off-by: Mario Dominguez <[email protected]>

Refs #20584: Fix

77cab0d

Signed-off-by: Mario Dominguez <[email protected]>

Refs #20584: Update LivelinessManager tests

3d3e524

Signed-off-by: Mario Dominguez <[email protected]>

Refs #20584: Linter

cd799a0

Signed-off-by: Mario Dominguez <[email protected]>

Refs #20584: Apply reviewer suggestions

33ebb96

Signed-off-by: Mario Dominguez <[email protected]>

Refs #20584: Fix PubSubParticipant comparison and add padding between…

85c5d4d

… writer announcement period and lease duration test's writers Signed-off-by: Mario Dominguez <[email protected]>

EduPonz force-pushed the bugfix/20584 branch from 89f0b06 to 85c5d4d Compare March 20, 2024 18:53

EduPonz removed the ci-pending PR which CI is running label Mar 21, 2024

EduPonz merged commit f708244 into master Mar 21, 2024
13 of 15 checks passed

EduPonz deleted the bugfix/20584 branch March 21, 2024 06:47

mergify bot mentioned this pull request Mar 21, 2024

[20584] Effectively assert automatic/manual_by_participant liveliness (backport #4501) #4594

Merged

12 tasks

mergify bot mentioned this pull request Mar 21, 2024

[20584] Effectively assert automatic/manual_by_participant liveliness (backport #4501) #4595

Merged

12 tasks

mergify bot mentioned this pull request Mar 21, 2024

[20584] Effectively assert automatic/manual_by_participant liveliness (backport #4501) #4596

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20584] Effectively assert automatic/manual_by_participant liveliness #4501

[20584] Effectively assert automatic/manual_by_participant liveliness #4501

Mario-DL commented Mar 5, 2024 •

edited by EduPonz

Loading

Mario-DL commented Mar 5, 2024

MiguelCompany commented Mar 11, 2024

mergify bot commented Mar 11, 2024

JesusPoderoso commented Mar 13, 2024

Mario-DL commented Mar 14, 2024

EduPonz commented Mar 20, 2024

mergify bot commented Mar 20, 2024

EduPonz commented Mar 20, 2024

EduPonz commented Mar 21, 2024

mergify bot commented Mar 21, 2024 •

edited

Loading

[20584] Effectively assert automatic/manual_by_participant liveliness #4501

[20584] Effectively assert automatic/manual_by_participant liveliness #4501

Conversation

Mario-DL commented Mar 5, 2024 • edited by EduPonz Loading

Description

Contributor Checklist

Reviewer Checklist

Mario-DL commented Mar 5, 2024

MiguelCompany commented Mar 11, 2024

mergify bot commented Mar 11, 2024

✅ Branch has been successfully rebased

JesusPoderoso commented Mar 13, 2024

Mario-DL commented Mar 14, 2024

EduPonz commented Mar 20, 2024

mergify bot commented Mar 20, 2024

✅ Branch has been successfully rebased

EduPonz commented Mar 20, 2024

EduPonz commented Mar 21, 2024

mergify bot commented Mar 21, 2024 • edited Loading

✅ Backports have been created

Mario-DL commented Mar 5, 2024 •

edited by EduPonz

Loading

mergify bot commented Mar 21, 2024 •

edited

Loading