Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20739] Refactor IStatusQueryable and make monitor service interfaces private #4651

Merged
merged 10 commits into from
Apr 17, 2024
Merged

[20739] Refactor IStatusQueryable and make monitor service interfaces private #4651

merged 10 commits into from
Apr 17, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Apr 4, 2024 •
edited by EduPonz
Loading

Description

This PR brings to master the work from #4640 commit a2f4664 and 7a0c328. It refactors the IStatusQueryable() interface and make monitor service interfaces private (except from IProxyQueryable.hpp as PDP.h is still public in master and implements it).

@Mergifyio backport 2.13.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: [20739] Remove ddsentitystatus from docs Fast-DDS-docs#745
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v2.14.1 milestone Apr 4, 2024
@Mario-DL Mario-DL requested a review from JLBuenoLopez April 4, 2024 08:27
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 4, 2024
@Mario-DL Mario-DL requested a review from richiware April 4, 2024 08:33
@Mario-DL Mario-DL mentioned this pull request Apr 4, 2024
Closed
12 tasks
JLBuenoLopez
JLBuenoLopez suggested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks

src/cpp/fastdds/subscriber/SubscriberImpl.hpp Outdated Show resolved Hide resolved
src/cpp/statistics/rtps/monitor-service/MonitorService.cpp Outdated Show resolved Hide resolved
@Mario-DL
Refs 20739: Rev 2 changes
a81affa 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL requested a review from JLBuenoLopez April 4, 2024 13:11
@Mario-DL
Copy link
Member Author

Mario-DL commented Apr 4, 2024

@richiprosima please test this

@Mario-DL
Refs 20739: Linter
97abb94 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL
Refs 20739: Rev 3 changes
82a8b06 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL requested a review from JLBuenoLopez April 5, 2024 10:06
@Mario-DL
Copy link
Member Author

Mario-DL commented Apr 5, 2024

@richiprosima please test this

@Mario-DL
Refs #20739: Remove status assert
2b3b3f7 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL requested review from JLBuenoLopez and removed request for JLBuenoLopez April 9, 2024 05:39
JLBuenoLopez
JLBuenoLopez previously approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL
Copy link
Member Author

Mario-DL commented Apr 9, 2024

@richiprosima please test this

EduPonz
EduPonz suggested changes Apr 16, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mario-DL please address documentation build failure

@Mario-DL
Refs #20739: Comment typo
a560343 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL requested a review from EduPonz April 16, 2024 09:13
@Mario-DL Mario-DL mentioned this pull request Apr 16, 2024
Merged
8 tasks
EduPonz
EduPonz approved these changes Apr 16, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz
Copy link

EduPonz commented Apr 17, 2024

I'm seeing the same Github Windows errors in nightlies and other PR and seem to have something to do with the runners infra, so I'm merging this one.

@EduPonz EduPonz merged commit fb841b9 into master Apr 17, 2024
10 of 12 checks passed
@EduPonz EduPonz deleted the fix/20739 branch April 17, 2024 04:57
@EduPonz
Copy link

EduPonz commented Apr 17, 2024

@Mergifyio backport 2.13.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024 •
edited
Loading

backport 2.13.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 17, 2024
@Mario-DL @mergify
Refactor IStatusQueryable and make monitor service interfaces private (…
8b7a86e 
…#4651)

* Refs #20739: Make monitor service interfaces private (except IProxyQueryable)

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Replace tabs with spaces in monitorservice_types.idl

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Refactor include and src files

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Refactor tests

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Apply suggestion regarding asserts

Signed-off-by: Mario Dominguez <[email protected]>

* Refs 20739: Rev 2 changes

Signed-off-by: Mario Dominguez <[email protected]>

* Refs 20739: Linter

Signed-off-by: Mario Dominguez <[email protected]>

* Refs 20739: Rev 3 changes

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Remove status assert

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Comment typo

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit fb841b9)

# Conflicts:
#	include/fastdds/rtps/reader/RTPSReader.h
#	include/fastdds/rtps/writer/RTPSWriter.h
This was referenced Apr 17, 2024
Merged
Merged
EduPonz pushed a commit that referenced this pull request May 24, 2024
@mergify @Mario-DL @JesusPoderoso
Refactor IStatusQueryable and make monitor service interfaces private (…
4ca144e 
…#4651) (#4687)

* Refactor IStatusQueryable and make monitor service interfaces private (#4651)

* Refs #20739: Make monitor service interfaces private (except IProxyQueryable)

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Replace tabs with spaces in monitorservice_types.idl

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Refactor include and src files

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Refactor tests

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Apply suggestion regarding asserts

Signed-off-by: Mario Dominguez <[email protected]>

* Refs 20739: Rev 2 changes

Signed-off-by: Mario Dominguez <[email protected]>

* Refs 20739: Linter

Signed-off-by: Mario Dominguez <[email protected]>

* Refs 20739: Rev 3 changes

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Remove status assert

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #20739: Comment typo

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit fb841b9)

# Conflicts:
#	include/fastdds/rtps/reader/RTPSReader.h
#	include/fastdds/rtps/writer/RTPSWriter.h

* Fix conflicts based on original PR

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

@JLBuenoLopez JLBuenoLopez JLBuenoLopez left review comments

@richiware richiware Awaiting requested review from richiware

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @EduPonz @JLBuenoLopez