-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20739] Refactor IStatusQueryable and make monitor service interfaces private (backport #4651) #4687
Conversation
…#4651) * Refs #20739: Make monitor service interfaces private (except IProxyQueryable) Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Replace tabs with spaces in monitorservice_types.idl Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Refactor include and src files Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Refactor tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Apply suggestion regarding asserts Signed-off-by: Mario Dominguez <[email protected]> * Refs 20739: Rev 2 changes Signed-off-by: Mario Dominguez <[email protected]> * Refs 20739: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs 20739: Rev 3 changes Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Remove status assert Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Comment typo Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit fb841b9) # Conflicts: # include/fastdds/rtps/reader/RTPSReader.h # include/fastdds/rtps/writer/RTPSWriter.h
Cherry-pick of fb841b9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: JesusPoderoso <[email protected]>
@richiprosima please test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
CI issues are unrelated to the PR content |
Description
This PR brings to
master
the work from #4640 commit a2f4664 and 7a0c328. It refactors theIStatusQueryable()
interface and make monitor service interfaces private (except fromIProxyQueryable.hpp
asPDP.h
is still public inmaster
and implements it).@Mergifyio backport 2.13.x
Contributor Checklist
versions.md
file (if applicable).Related documentation PR: [20739] Remove ddsentitystatus from docs Fast-DDS-docs#745
Reviewer Checklist
This is an automatic backport of pull request #4651 done by [Mergify](https://mergify.com).