[20310] Feature: topic keys with non breaking ABI #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
…rs_array in the parent messagemembers Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
requested changes
Feb 14, 2024
Comment on lines
99
to
100
| /// Array of the same size as the numebr of fields that indicates | ||
| /// whether a field is keyed or not |
There was a problem hiding this comment.
Suggested change
| /// Array of the same size as the numebr of fields that indicates | |
| /// whether a field is keyed or not | |
| /// A pointer to the array that indicates whether each field is annotated as @key |
rosidl_typesupport_introspection_c/include/rosidl_typesupport_introspection_c/identifier.h
Show resolved
Hide resolved
...dl_typesupport_introspection_cpp/include/rosidl_typesupport_introspection_cpp/identifier.hpp
Show resolved
Hide resolved
Comment on lines
106
to
107
| /// Array of the same size as the numebr of fields that indicates | ||
| /// whether a field is keyed or not |
There was a problem hiding this comment.
Suggested change
| /// Array of the same size as the numebr of fields that indicates | |
| /// whether a field is keyed or not | |
| /// A pointer to the array that indicates whether each field is annotated as @key |
Signed-off-by: Mario Dominguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the changes in
rosidlin order to support the topic keys feature without breaking ABI.Note: This branch starts from the previous work from #1