Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create annotation to opt into activity open tracing #1345

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Sep 11, 2024

Goal

Restrict the activities for which loading will be traced. Initially, we will look for a specific annotation on an Activity, but ways to specify this will be added in later PRs.

Testing

Add unit tests

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs KDoc for the annotation that forms part of our new public API

@bidetofevil bidetofevil force-pushed the hho/open-event-emitter branch 2 times, most recently from f6ca940 to b27c99c Compare November 29, 2024 18:22
@bidetofevil bidetofevil changed the base branch from hho/open-event-emitter to graphite-base/1345 November 29, 2024 18:34
@bidetofevil bidetofevil changed the base branch from graphite-base/1345 to main November 29, 2024 18:38
Copy link
Collaborator Author

bidetofevil commented Nov 29, 2024

Merge activity

  • Nov 29, 1:38 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Nov 29, 1:49 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit aa2f36a into main Nov 29, 2024
6 of 9 checks passed
@bidetofevil bidetofevil deleted the hho/activity-trace-opt-in branch November 29, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants