-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create annotation to opt into activity open tracing #1345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2024
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
September 11, 2024 05:02
0e1d93e
to
044d183
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
September 11, 2024 05:02
71032f6
to
cb09170
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
September 11, 2024 16:57
044d183
to
c6a07c0
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
September 11, 2024 16:57
cb09170
to
03b7c20
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
September 12, 2024 06:59
c6a07c0
to
8294561
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
September 12, 2024 06:59
03b7c20
to
ff561f2
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
September 12, 2024 15:39
8294561
to
2afc05f
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
September 12, 2024 15:39
ff561f2
to
a7e1f21
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
September 13, 2024 06:08
2afc05f
to
ab9cfd9
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
September 13, 2024 06:09
a7e1f21
to
f0a34a7
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
September 13, 2024 07:13
ab9cfd9
to
3180666
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
September 13, 2024 07:13
f0a34a7
to
11d9608
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
September 13, 2024 07:13
3180666
to
dd74c17
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
September 13, 2024 07:14
11d9608
to
f5bd6af
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
September 14, 2024 05:49
dd74c17
to
785f4c9
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
September 14, 2024 05:49
f5bd6af
to
168c3f0
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
September 16, 2024 03:46
785f4c9
to
78dfc66
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
September 16, 2024 03:46
168c3f0
to
6400e13
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
September 18, 2024 06:15
78dfc66
to
4768784
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
September 18, 2024 06:15
6400e13
to
19a8def
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
September 19, 2024 18:28
4768784
to
cba7561
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
September 19, 2024 18:28
19a8def
to
cb864cf
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
November 9, 2024 00:12
1d16c73
to
5b4cbfe
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
2 times, most recently
from
November 9, 2024 05:50
67d0caf
to
107f58a
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
November 13, 2024 18:38
5b4cbfe
to
52b31dc
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
November 13, 2024 18:38
107f58a
to
05296c1
Compare
bidetofevil
requested review from
fractalwrench,
fnewberg and
a team
as code owners
November 13, 2024 19:01
This was referenced Nov 14, 2024
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
November 28, 2024 17:22
52b31dc
to
54431ea
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
2 times, most recently
from
November 28, 2024 17:40
8b19675
to
2966135
Compare
fractalwrench
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but needs KDoc for the annotation that forms part of our new public API
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
November 29, 2024 16:41
de0c371
to
d320798
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
November 29, 2024 16:41
2966135
to
3ba7d00
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
from
November 29, 2024 18:10
d320798
to
d13a3e9
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
November 29, 2024 18:10
3ba7d00
to
f0b9b86
Compare
bidetofevil
force-pushed
the
hho/open-event-emitter
branch
2 times, most recently
from
November 29, 2024 18:22
f6ca940
to
b27c99c
Compare
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
November 29, 2024 18:22
f0b9b86
to
2530415
Compare
bidetofevil
changed the base branch from
hho/open-event-emitter
to
graphite-base/1345
November 29, 2024 18:34
bidetofevil
force-pushed
the
hho/activity-trace-opt-in
branch
from
November 29, 2024 18:38
2530415
to
f530e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Restrict the activities for which loading will be traced. Initially, we will look for a specific annotation on an Activity, but ways to specify this will be added in later PRs.
Testing
Add unit tests