-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create OS-specific implementations of the ActivityLoadEventEmitter #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2024
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 15, 2024 15:07
5b674be
to
88fb9fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
+ Coverage 85.34% 85.36% +0.02%
==========================================
Files 463 463
Lines 10698 10706 +8
Branches 1600 1600
==========================================
+ Hits 9130 9139 +9
Misses 852 852
+ Partials 716 715 -1
|
bidetofevil
requested review from
fractalwrench and
priettt
and removed request for
a team
November 15, 2024 15:51
fractalwrench
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bidetofevil
force-pushed
the
hho/ui-load-naming
branch
from
November 28, 2024 17:22
61b6940
to
96de3d0
Compare
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 28, 2024 17:22
88fb9fe
to
7219d4e
Compare
bidetofevil
force-pushed
the
hho/ui-load-naming
branch
from
November 28, 2024 17:40
96de3d0
to
20d94b0
Compare
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 28, 2024 17:40
7219d4e
to
46875a1
Compare
bidetofevil
force-pushed
the
hho/ui-load-naming
branch
from
November 29, 2024 16:42
20d94b0
to
bdb9785
Compare
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 29, 2024 16:42
46875a1
to
64ba849
Compare
bidetofevil
force-pushed
the
hho/ui-load-naming
branch
from
November 29, 2024 18:11
bdb9785
to
72bcfac
Compare
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 29, 2024 18:11
64ba849
to
6d4a34c
Compare
bidetofevil
force-pushed
the
hho/ui-load-naming
branch
from
November 29, 2024 18:25
72bcfac
to
406a400
Compare
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 29, 2024 18:25
6d4a34c
to
14ef646
Compare
bidetofevil
force-pushed
the
hho/ui-load-naming
branch
from
November 29, 2024 18:51
406a400
to
b7ebda2
Compare
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 29, 2024 18:52
14ef646
to
340fba8
Compare
bidetofevil
force-pushed
the
hho/ui-load-naming
branch
from
November 29, 2024 19:04
b7ebda2
to
0098beb
Compare
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 29, 2024 19:04
340fba8
to
bb29b4b
Compare
bidetofevil
force-pushed
the
hho/ui-load-naming
branch
from
November 29, 2024 19:15
0098beb
to
08c260c
Compare
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 29, 2024 19:16
bb29b4b
to
d890ed6
Compare
bidetofevil
force-pushed
the
hho/ui-load-naming
branch
2 times, most recently
from
November 29, 2024 19:28
79870f7
to
5abae2a
Compare
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 29, 2024 19:28
d890ed6
to
56df539
Compare
bidetofevil
changed the base branch from
hho/ui-load-naming
to
graphite-base/1683
November 29, 2024 19:40
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 29, 2024 19:40
56df539
to
b21e317
Compare
bidetofevil
force-pushed
the
hho/split-load-event-emitters
branch
from
November 29, 2024 19:41
b21e317
to
f37bc95
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Split out OS version specific handling of UiLoad events into separate classes. Tried to use a delegate but couldn't get it to work properly, so I just created two implementation with a shared object to handle common functionality. Good ol' situation where composition vs inheritance has no obvious winner, so I just picked one.
Testing
Tweaked existing tests to make sure things work