Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create callback mechanism to run code post app startup #1346

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Create callback mechanism to run code post app startup #1346

merged 1 commit into from
Nov 29, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Sep 11, 2024 •
edited
Loading

Goal

Add the ability to invoke a callback when an app startup trace is ready to be logged. This mechanism will be used to hook up the UiLoadEventEmitter in a subsequent PR

@bidetofevil Graphite App
Copy link
Collaborator Author

bidetofevil commented Sep 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Sep 11, 2024
Merged
Merged
Merged
This was referenced Sep 11, 2024
Merged
Merged
Merged
@bidetofevil bidetofevil mentioned this pull request Sep 12, 2024
Merged
@bidetofevil bidetofevil force-pushed the hho/startup-complete-callback branch 2 times, most recently from e57afda to 55d7be3 Compare November 13, 2024 19:42
@bidetofevil bidetofevil marked this pull request as ready for review November 13, 2024 19:48
@bidetofevil bidetofevil requested a review from a team as a code owner November 13, 2024 19:48
This was referenced Nov 14, 2024
Merged
Merged
fractalwrench
fractalwrench approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil changed the base branch from hho/activity-trace-opt-in to graphite-base/1346 November 29, 2024 18:49
@bidetofevil bidetofevil changed the base branch from graphite-base/1346 to main November 29, 2024 18:50
@github-actions GitHub Actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@bidetofevil bidetofevil merged commit 451f939 into main Nov 29, 2024
6 checks passed
@bidetofevil Graphite App
Copy link
Collaborator Author

Merge activity

  • Nov 29, 2:02 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil deleted the hho/startup-complete-callback branch November 29, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractalwrench fractalwrench fractalwrench approved these changes

@priettt priettt Awaiting requested review from priettt

@fnewberg fnewberg Awaiting requested review from fnewberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bidetofevil @fractalwrench