Skip to content
This repository has been archived by the owner on May 17, 2022. It is now read-only.

Modify reference to ethereum/wiki, remove ethereum/wiki from legacy docs as it is actively maintained (moreso than this repo) and place it prominently as an alternative to this repo/site #440

Merged
merged 3 commits into from
May 7, 2018

Conversation

jamesray1
Copy link
Contributor

@jamesray1 jamesray1 commented May 3, 2018

No description provided.

pirapira
pirapira previously approved these changes May 3, 2018
Copy link
Member

@pirapira pirapira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jamesray1
Copy link
Contributor Author

Before you merge this, I will reference the wiki.

@paulvi
Copy link

paulvi commented May 3, 2018

Great.

There are others things to do to clear up status of the docs. Let it be in #441

@paulvi
Copy link

paulvi commented May 3, 2018

OK, waiting for merge

than https://github.com/ethereum/homestead-guide/blob/master/source/index.rst would need to be changed as it is front page http://ethdocs.org/en/latest/

then #439 would be closed

@pirapira pirapira dismissed their stale review May 3, 2018 09:43

Suddenly the PR retires the homestead guide. I'll make a shout on gitter.im/ethereum/homestead-guide.

@jamesray1 jamesray1 changed the title Remove ethereum/wiki from legacy docs as it is actively maintained (moreso than this repo) Modify reference to ethereum/wiki, remove ethereum/wiki from legacy docs as it is actively maintained (moreso than this repo) and place it prominently as an alternative to this repo/site May 3, 2018
@paulvi
Copy link

paulvi commented May 3, 2018

Suddenly the PR retires the homestead guide. I'll make a shout on gitter.im/ethereum/homestead-guide.

Possibly something was configured outside of this repo...

The title now is more than descriptive, it says all

@paulvi paulvi mentioned this pull request May 3, 2018
@pirapira
Copy link
Member

pirapira commented May 4, 2018

@paulvi this sentence retires the Homestead guide

The Guide may be considered to be a historic reference since Ethereum had the Metropolis phase 1 fork,

@paulvi
Copy link

paulvi commented May 4, 2018

yes, but not immediately.

First step is within README to guide where docs updates should go.

@paulvi
Copy link

paulvi commented May 4, 2018

please merge

@pirapira
Copy link
Member

pirapira commented May 4, 2018

I've asked if anybody is interested to upgrade the Homestead guide. https://gitter.im/ethereum/homestead-guide I'll give them 48 hours to respond.

@pirapira
Copy link
Member

pirapira commented May 4, 2018

@paulvi are you blocked on this PR somehow?

@pirapira
Copy link
Member

pirapira commented May 4, 2018

I don't want back-and-forth. If we retire it, we do it completely, like changing the colors of text so it looks obsolete, etc. I first need some silence on that channel first because if anybody wants to update this repo, this document cannot be considered as a historic one.

@paulvi
Copy link

paulvi commented May 4, 2018

What should be there is one place to be called "Ethereum docs".

Currently it is wiki/wiki vs http://ethdocs.org (this repo)

And with this PR it would be retiring.

I've asked if anybody is interested to upgrade the Homestead guide. https://gitter.im/ethereum/homestead-guide I'll give them 48 hours to respond.

That is pretty good. After few days (weekend), go on with updates.
Also #443 http://ethdocs.org target can be changed.

@pirapira
Copy link
Member

pirapira commented May 4, 2018

should be there is one place to be called "Ethereum docs".

No I don't think so.

I just want to clarify if this repo is retired or not.

@pirapira pirapira merged commit 1c1c597 into ethereum:master May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants