-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite type system and compiler (v4) #35
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 89.04% 91.40% +2.36%
==========================================
Files 20 20
Lines 1862 2106 +244
==========================================
+ Hits 1658 1925 +267
+ Misses 204 181 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3f84516
to
ee0786c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 89.32% 92.00% +2.68%
==========================================
Files 21 20 -1
Lines 1929 2115 +186
==========================================
+ Hits 1723 1946 +223
+ Misses 206 169 -37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: cecinestpasunepipe <[email protected]>
Co-authored-by: cecinestpasunepipe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that shouldn't have been a self-requested review ;)
TODO:
(DIS-75, DIS-77, DIS-103, DIS-104, DIS-965, DIS-1087, DIS-1124, DIS-1970)